From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/1] add support for Seagate BlackArmor NAS220
Date: Thu, 25 Dec 2014 15:12:40 +0100 [thread overview]
Message-ID: <20141225141240.GJ19265@lunn.ch> (raw)
In-Reply-To: <549C1465.6030909@gmail.com>
> >Hi Sebastian
> >
> >I'm not sure what you mean here. The binding Documentation says:
>
> I was hoping that using phys/phy-names would allow us to get rid of
> nr-ports property. I haven't checked the corresponding code and likely
> will not before next year, but we should try to get rid of the nr-ports
> property completely.
>
> >Required Properties:
> >- compatibility : "marvell,orion-sata" or "marvell,armada-370-sata"
> >- reg : Address range of controller
> >- interrupts : Interrupt controller is using
> >- nr-ports : Number of SATA ports in use.
> >
> >Optional Properties:
> >- phys : List of phandles to sata phys
> >- phy-names : Should be "0", "1", etc, one number per phandle
> >
> >The optional phys/phy-names have just been added to
> >kirkwood-6192.dtsi.
>
> Yeah, saw that patch after the review.. and my understanding of the
> phys/phy-names properties is that
> (a) they allow to count the number of _available_ ports
> (b) they allow to determine the number of _used_ ports
> (c) they allow to e.g. disable port 0 but enable port 1
>
> while nr-ports only allows (a). You can derive (b) only if you use
> the first out of two but you cannot do (c) with nr-ports.
>
> Which is why we introduced the phys/phy-names properties.
We introduced them for turning the phys on and off.
We don't do any derivation from this information. It is the same for
all devices, since it is in the kirkwood-*.dtsi file, not per board.
Also, orion5x does not allow such control of the phys, they are always
on. So i don't know if we can derive anything from this information,
since it is not always present.
Andrew
next prev parent reply other threads:[~2014-12-25 14:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 20:38 [PATCH 2/2] ARM: dts: kirkwood: add dts support for Seagate BlackArmor NAS220 Evgeni Dobrev
2014-12-16 8:56 ` Andrew Lunn
2014-12-16 16:37 ` Evgeni Dobrev
2014-12-16 19:20 ` Andrew Lunn
2014-12-22 8:04 ` [PATCH v2 0/1] add " Evgeni Dobrev
2014-12-22 8:04 ` [PATCH v2 1/1] " Evgeni Dobrev
2014-12-22 10:02 ` Andrew Lunn
2014-12-22 12:57 ` [PATCH v3 0/1] " Evgeni Dobrev
2014-12-22 12:57 ` [PATCH v3 1/1] " Evgeni Dobrev
2014-12-23 11:31 ` Andrew Lunn
2014-12-25 13:08 ` Sebastian Hesselbarth
2014-12-25 13:31 ` Andrew Lunn
2014-12-25 13:43 ` Sebastian Hesselbarth
2014-12-25 14:12 ` Andrew Lunn [this message]
2014-12-25 15:19 ` Sebastian Hesselbarth
2014-12-26 11:06 ` Evgeni Dobrev
2014-12-28 10:46 ` [PATCH v4 0/1] " Evgeni Dobrev
2014-12-28 10:46 ` [PATCH v4 1/1] " Evgeni Dobrev
2015-01-05 18:05 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141225141240.GJ19265@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox