From: shawn.guo@linaro•org (Shawn Guo)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: dts: imx51-babbage: Fix ULPI PHY reset modelling
Date: Tue, 6 Jan 2015 21:41:41 +0800 [thread overview]
Message-ID: <20150106134140.GB21729@dragon> (raw)
In-Reply-To: <1420551365.2333.15.camel@pengutronix.de>
On Tue, Jan 06, 2015 at 02:36:05PM +0100, Lucas Stach wrote:
> Am Dienstag, den 06.01.2015, 20:43 +0800 schrieb Shawn Guo:
> > On Mon, Jan 05, 2015 at 03:19:08PM -0200, Fabio Estevam wrote:
> > > GPIO2_5 is the reset GPIO for the USB3317 ULPI PHY. Instead of modelling it as
> > > a regulator, the correct approach is to use the 'reset_gpios' property of the
> > > "usb-nop-xceiv" node.
> > >
> > > GPIO1_7 is the reset GPIO for the USB2517 USB hub. As we currently don't have
> > > dt bindings to describe a HUB reset, let's keep using the regulator approach.
> > >
> > > Rename the regulator to 'reg_hub_reset' to better describe its function and bind
> > > it with the USB host1 port instead.
> > >
> > > USB host support has been introduced by commit 9bf206a9d13be3 ("ARM: dts:
> > > imx51-babbage: Add USB Host1 support"), which landed in 3.16 and it seems that
> > > USB has only been functional due to previous bootloader initialization.
> > >
> > > With this patch applied we can get USB host to work without relying on the
> > > bootloader.
> > >
> > > Cc: <stable@vger•kernel.org> # 3.16+
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale•com>
> >
> > Applied, thanks.
> >
> For the record:
> I'm not happy with this patch. It still abuses the regulator API for
> something completely unrelated and this may well break again in the
> future. But given that it fixes an actual regression and you already
> sent a pull including this I'm okay to keep it.
>
> We still need a proper fix to handle ULPI resets to get rid of this
> hackery.
Yeah, at least this fix patch removes one user of the regulator hackery.
Shawn
next prev parent reply other threads:[~2015-01-06 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 17:19 [PATCH] ARM: dts: imx51-babbage: Fix ULPI PHY reset modelling Fabio Estevam
2015-01-06 12:43 ` Shawn Guo
2015-01-06 13:36 ` Lucas Stach
2015-01-06 13:41 ` Shawn Guo [this message]
2015-01-06 13:47 ` Fabio Estevam
2015-01-06 13:54 ` Lucas Stach
2015-01-06 13:59 ` Fabio Estevam
2015-01-06 14:03 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106134140.GB21729@dragon \
--to=shawn.guo@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox