From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] arm64: don't make early_*map() calls post paging_init()
Date: Wed, 7 Jan 2015 10:58:41 +0000 [thread overview]
Message-ID: <20150107105841.GE7485@arm.com> (raw)
In-Reply-To: <1420576522.16211.30.camel@t520.localdomain>
On Tue, Jan 06, 2015 at 08:35:22PM +0000, Mark Salter wrote:
> On Tue, 2015-01-06 at 13:41 +0000, Leif Lindholm wrote:
> > diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
> > index 6fac253..e311066 100644
> > --- a/arch/arm64/kernel/efi.c
> > +++ b/arch/arm64/kernel/efi.c
> > @@ -313,17 +313,26 @@ void __init efi_init(void)
> > memmap.desc_size = params.desc_size;
> > memmap.desc_version = params.desc_ver;
> >
> > - if (uefi_init() < 0)
> > - return;
> > + if (uefi_init() >= 0)
> > + reserve_regions();
> >
> > - reserve_regions();
> > + early_memunmap(memmap.map, params.mmap_size);
> > }
> >
> > -void __init efi_idmap_init(void)
> > +void __init efi_memmap_init(void)
> > {
> > + u64 mapsize;
> > +
> > if (!efi_enabled(EFI_BOOT))
> > return;
> >
> > + /* replace early memmap mapping with permanent mapping */
> > + mapsize = memmap.map_end - memmap.map;
> > + memmap.map = (__force void *)ioremap_cache((phys_addr_t)memmap.phys_map,
> > + mapsize);
>
> ioremap_cache() could potententially fail here if the phys_map address
> doesn't have a valid pfn (not in the kernel linear ram mapping) because
> some of the underlying vm support hasn't been initialized yet.
Can you be more specific about the case you have in mind, please? pfn_valid
uses the memblocks on arm64, and that should all have been sorted out in
paging_init(). What's the issue that you're anticipating?
Will
next prev parent reply other threads:[~2015-01-07 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 13:41 [PATCH v2 0/2] arm64: don't call early_*map() post paging_init() Leif Lindholm
2015-01-06 13:41 ` [PATCH v2 1/2] arm64: don't make early_*map() calls " Leif Lindholm
2015-01-06 20:35 ` Mark Salter
2015-01-07 10:58 ` Will Deacon [this message]
2015-01-07 13:13 ` Ard Biesheuvel
2015-01-07 13:31 ` Leif Lindholm
2015-01-07 19:03 ` Will Deacon
2015-01-06 13:41 ` [PATCH v2 2/2] arm64: call early_ioremap_reset() in paging_init() Leif Lindholm
2015-01-06 13:59 ` [PATCH v2 0/2] arm64: don't call early_*map() post paging_init() Will Deacon
2015-01-06 14:04 ` Ard Biesheuvel
2015-01-06 15:52 ` Leif Lindholm
2015-01-06 15:54 ` Ard Biesheuvel
2015-01-06 16:05 ` Will Deacon
2015-01-06 16:23 ` Ard Biesheuvel
2015-01-06 19:18 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107105841.GE7485@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox