Subject: [PATCH v9 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

From: [email-masked] (Baruch Siach)
Date: Wed, 28 Jan 2015 11:54:01 +0200

Hi Lyra Zhang,

On Wed, Jan 28, 2015 at 04:46:33PM +0800, Lyra Zhang wrote:
> On Wed, Jan 28, 2015 at 2:12 PM, Baruch Siach <[email-masked]> wrote:
> > On Wed, Jan 28, 2015 at 10:47:41AM +0800, Chunyan Zhang wrote:
> >> +             if (uart_handle_sysrq_char(port, ch))
> >> +                     continue;
> >
> > My comment[1] on a previous version of this patch still stands.
> > uart_handle_sysrq_char is a NOP when SUPPORT_SYSRQ is not defined.
> 
> yes, there are two definitions in serial_core.h, and it returns 0 when
> SUPPORT_SYSRQ is not defined.
> so, I think my code behavior does not hurt, right?

Right. I just wanted to point out that you can easily define SUPPORT_SYSRQ as 
appropriate like many other serial drivers do to get sysrq support.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -