From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8 14/21] ACPI / processor: Make it possible to get CPU hardware ID via GICC
Date: Mon, 9 Feb 2015 06:55:12 +0000 [thread overview]
Message-ID: <20150209065512.GK13969@arm.com> (raw)
In-Reply-To: <1422881149-8177-15-git-send-email-hanjun.guo@linaro.org>
On Mon, Feb 02, 2015 at 12:45:42PM +0000, Hanjun Guo wrote:
> Introduce a new function map_gicc_mpidr() to allow MPIDRs to be obtained
> from the GICC Structure introduced by ACPI 5.1.
>
> MPIDR is the CPU hardware ID as local APIC ID on x86 platform, so we use
> MPIDR not the GIC CPU interface ID to identify CPUs.
>
> Further steps would typedef a phys_id_t for in arch code(with
> appropriate size and a corresponding invalid value, say ~0) and use that
> instead of an int in drivers/acpi/processor_core.c to store phys_id, then
> no need for mpidr packing.
>
> CC: Rafael J. Wysocki <rjw@rjwysocki•net>
> CC: Catalin Marinas <catalin.marinas@arm•com>
> CC: Will Deacon <will.deacon@arm•com>
> Tested-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd•com>
> Tested-by: Yijing Wang <wangyijing@huawei•com>
> Tested-by: Mark Langsdorf <mlangsdo@redhat•com>
> Tested-by: Jon Masters <jcm@redhat•com>
> Tested-by: Timur Tabi <timur@codeaurora•org>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro•org>
> ---
> arch/arm64/include/asm/acpi.h | 30 ++++++++++++++++++++++++++++++
> drivers/acpi/processor_core.c | 37 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 67 insertions(+)
>
> diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h
> index 8984aa5..7e825b9 100644
> --- a/arch/arm64/include/asm/acpi.h
> +++ b/arch/arm64/include/asm/acpi.h
> @@ -12,6 +12,8 @@
> #ifndef _ASM_ACPI_H
> #define _ASM_ACPI_H
>
> +#include <asm/smp_plat.h>
> +
> /* Basic configuration for ACPI */
> #ifdef CONFIG_ACPI
> #define acpi_strict 1 /* No out-of-spec workarounds on ARM64 */
> @@ -45,6 +47,34 @@ static inline void enable_acpi(void)
> acpi_noirq = 0;
> }
>
> +/* MPIDR value provided in GICC structure is 64 bits, but the
> + * existing phys_id (CPU hardware ID) using in acpi processor
> + * driver is 32-bit, to conform to the same datatype we need
> + * to repack the GICC structure MPIDR.
> + *
> + * bits other than following 32 bits are defined as 0, so it
> + * will be no information lost after repacked.
> + *
> + * Bits [0:7] Aff0;
> + * Bits [8:15] Aff1;
> + * Bits [16:23] Aff2;
> + * Bits [32:39] Aff3;
> + */
> +static inline u32 pack_mpidr(u64 mpidr)
> +{
> + return (u32) ((mpidr & 0xff00000000) >> 8) | mpidr;
> +}
I'm a bit puzzled by this packing:
- Bit 31 of the MPIDR is RES1. Do we need to mask it out first?
- How does this work for uniprocessor systems where bit 30 is set?
- Similarly for mythical multi-threaded implementations with bit 24 set.
Will
next prev parent reply other threads:[~2015-02-09 6:55 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 12:45 [PATCH v8 00/21] Introduce ACPI for ARM64 based on ACPI 5.1 Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 01/21] acpi: add arm64 to the platforms that use ioremap Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64 Hanjun Guo
2015-02-02 22:14 ` Rafael J. Wysocki
2015-02-03 9:08 ` Hanjun Guo
2015-02-03 11:37 ` Catalin Marinas
2015-02-03 11:41 ` Ard Biesheuvel
2015-02-03 17:29 ` Mark Salter
2015-02-03 22:04 ` Rafael J. Wysocki
2015-02-04 10:48 ` Russell King - ARM Linux
2015-02-04 13:22 ` Rafael J. Wysocki
2015-02-04 15:53 ` Bjorn Helgaas
2015-02-04 16:25 ` Russell King - ARM Linux
2015-02-04 16:38 ` David Woodhouse
2015-02-04 16:41 ` Bjorn Helgaas
2015-02-04 11:25 ` Catalin Marinas
2015-02-04 16:08 ` Mark Salter
2015-02-04 16:16 ` Timur Tabi
2015-02-04 17:52 ` Catalin Marinas
2015-02-04 17:57 ` Catalin Marinas
2015-02-04 18:58 ` Mark Salter
2015-02-05 10:41 ` Catalin Marinas
2015-02-05 10:47 ` Ard Biesheuvel
2015-02-05 10:59 ` Catalin Marinas
2015-02-05 11:14 ` Graeme Gregory
2015-02-05 12:07 ` Catalin Marinas
2015-02-05 12:52 ` Graeme Gregory
2015-02-05 14:50 ` Catalin Marinas
2015-02-05 12:55 ` Ard Biesheuvel
2015-02-05 13:54 ` Mark Salter
2015-02-05 16:42 ` [Linaro-acpi] " Al Stone
2015-02-05 17:48 ` Catalin Marinas
2015-02-05 22:16 ` Ard Biesheuvel
2015-02-06 10:36 ` Catalin Marinas
2015-02-06 11:08 ` Ard Biesheuvel
2015-02-06 14:16 ` Catalin Marinas
2015-02-07 1:44 ` Ard Biesheuvel
2015-02-05 1:24 ` Rafael J. Wysocki
2015-02-02 12:45 ` [PATCH v8 03/21] arm64: allow late use of early_ioremap Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 04/21] ARM64 / ACPI: Get RSDP and ACPI boot-time tables Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 05/21] ACPI / sleep: Introduce sleep_arm.c Hanjun Guo
2015-02-02 22:18 ` Rafael J. Wysocki
2015-02-03 16:18 ` Graeme Gregory
2015-02-02 12:45 ` [PATCH v8 06/21] ARM64 / ACPI: Introduce PCI stub functions for ACPI Hanjun Guo
2015-02-03 12:15 ` Catalin Marinas
2015-02-03 13:30 ` Hanjun Guo
2015-02-03 14:55 ` Rafael J. Wysocki
2015-02-04 9:06 ` Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 07/21] ARM64 / ACPI: Introduce early_param for "acpi" and pass acpi=force to enable ACPI Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 08/21] dt / chosen: Add linux, uefi-stub-generated-dtb property Hanjun Guo
2015-02-02 13:40 ` [PATCH v8 08/21] dt / chosen: Add linux,uefi-stub-generated-dtb property Leif Lindholm
2015-02-02 13:50 ` Graeme Gregory
2015-02-02 16:32 ` Mark Rutland
2015-02-06 10:34 ` [PATCH v8 08/21] dt / chosen: Add linux, uefi-stub-generated-dtb property G Gregory
2015-02-07 3:36 ` [PATCH v8 08/21] dt / chosen: Add linux,uefi-stub-generated-dtb property Hanjun Guo
2015-02-07 5:03 ` [PATCH v8 08/21] dt / chosen: Add linux, uefi-stub-generated-dtb property Ard Biesheuvel
2015-02-07 6:51 ` [PATCH v8 08/21] dt / chosen: Add linux,uefi-stub-generated-dtb property Hanjun Guo
2015-02-09 11:46 ` Mark Rutland
2015-02-11 2:44 ` [PATCH v8 08/21] dt / chosen: Add linux, uefi-stub-generated-dtb property Ard Biesheuvel
2015-02-11 6:33 ` [PATCH v8 08/21] dt / chosen: Add linux,uefi-stub-generated-dtb property Stefano Stabellini
2015-02-11 6:53 ` [PATCH v8 08/21] dt / chosen: Add linux, uefi-stub-generated-dtb property Ard Biesheuvel
2015-02-11 7:07 ` [PATCH v8 08/21] dt / chosen: Add linux,uefi-stub-generated-dtb property Stefano Stabellini
2015-02-02 12:45 ` [PATCH v8 09/21] ARM64 / ACPI: Disable ACPI if FADT revision is less than 5.1 Hanjun Guo
2015-02-03 17:20 ` Catalin Marinas
2015-02-04 9:38 ` Hanjun Guo
2015-02-04 13:06 ` Lorenzo Pieralisi
2015-02-05 9:45 ` Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 10/21] ARM64 / ACPI: If we chose to boot from acpi then disable FDT Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 11/21] ARM64 / ACPI: Get PSCI flags in FADT for PSCI init Hanjun Guo
2015-02-04 16:43 ` Lorenzo Pieralisi
2015-02-05 9:48 ` Hanjun Guo
2015-02-05 17:11 ` [Linaro-acpi] " Al Stone
2015-02-05 17:49 ` Lorenzo Pieralisi
2015-02-05 19:03 ` Al Stone
2015-02-06 7:56 ` Hanjun Guo
2015-02-06 16:21 ` Lorenzo Pieralisi
2015-02-02 12:45 ` [PATCH v8 12/21] ACPI / table: Print GIC information when MADT is parsed Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 13/21] ARM64 / ACPI: Parse MADT for SMP initialization Hanjun Guo
2015-02-03 13:53 ` Mark Rutland
2015-02-04 9:05 ` Hanjun Guo
2015-02-04 10:30 ` Mark Rutland
2015-02-05 9:20 ` Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 14/21] ACPI / processor: Make it possible to get CPU hardware ID via GICC Hanjun Guo
2015-02-03 14:17 ` Mark Rutland
2015-02-03 20:09 ` Catalin Marinas
2015-02-04 9:48 ` Hanjun Guo
2015-02-04 11:21 ` Catalin Marinas
2015-02-05 9:27 ` Hanjun Guo
2015-02-05 10:52 ` Catalin Marinas
2015-02-09 6:55 ` Will Deacon [this message]
2015-02-09 9:52 ` Catalin Marinas
2015-02-02 12:45 ` [PATCH v8 15/21] ARM64 / ACPI: Introduce ACPI_IRQ_MODEL_GIC and register device's gsi Hanjun Guo
2015-02-09 6:34 ` Will Deacon
2015-02-09 6:53 ` Hanjun Guo
2015-02-09 7:07 ` Will Deacon
2015-02-02 12:45 ` [PATCH v8 16/21] irqchip: Add GICv2 specific ACPI boot support Hanjun Guo
2015-02-02 22:23 ` Rafael J. Wysocki
2015-02-03 15:38 ` Tomasz Nowicki
2015-02-02 12:45 ` [PATCH v8 17/21] clocksource / arch_timer: Parse GTDT to initialize arch timer Hanjun Guo
2015-02-02 22:23 ` Rafael J. Wysocki
2015-02-03 13:28 ` Hanjun Guo
2015-02-04 18:59 ` Lorenzo Pieralisi
2015-02-05 10:11 ` Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 18/21] ARM64 / ACPI: Select ACPI_REDUCED_HARDWARE_ONLY if ACPI is enabled on ARM64 Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 19/21] ARM64 / ACPI: Enable ARM64 in Kconfig Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 20/21] Documentation: ACPI for ARM64 Hanjun Guo
2015-02-02 19:01 ` Timur Tabi
2015-02-03 8:44 ` Hanjun Guo
2015-02-02 12:45 ` [PATCH v8 21/21] arm64: ACPI: additions of ACPI documentation for arm64 Hanjun Guo
2015-02-04 0:40 ` Al Stone
2015-02-04 18:12 ` Mark Brown
2015-02-04 19:06 ` Al Stone
2015-02-05 2:02 ` Mark Brown
2015-02-03 16:47 ` [PATCH v8 00/21] Introduce ACPI for ARM64 based on ACPI 5.1 Mark Rutland
2015-02-03 17:43 ` [Linaro-acpi] " Al Stone
2015-02-04 9:41 ` Hanjun Guo
2015-02-04 20:29 ` Timur Tabi
2015-02-05 10:16 ` Hanjun Guo
2015-02-12 10:02 ` Robert Richter
2015-02-13 2:48 ` Hanjun Guo
2015-02-19 16:10 ` Robert Richter
[not found] ` <a314cdbbefb349acbb8f47d6e806989f@NASANEXM01D.na.qualcomm.com>
2015-02-13 0:50 ` Jonathan (Zhixiong) Zhang
2015-02-13 7:50 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209065512.GK13969@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox