From: sylvain.rochet@finsecur•com (Sylvain Rochet)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv6 4/5] USB: gadget: atmel_usba_udc: Prepare for IRQ single edge support
Date: Thu, 12 Feb 2015 19:00:29 +0100 [thread overview]
Message-ID: <20150212180029.GA8756@gradator.net> (raw)
In-Reply-To: <20150208102439.5be43f78@bbrezillon>
Hello Boris,
On Sun, Feb 08, 2015 at 10:24:39AM +0100, Boris Brezillon wrote:
> On Sat, 7 Feb 2015 20:37:23 +0100
> Sylvain Rochet <sylvain.rochet@finsecur•com> wrote:
>
> > If not, is udc->caps->irq_single_edge_support boolean acceptable ?
>
> Do you mean keeping the current approach ?
Yes!
> If you do, then maybe you can rework a bit the way you detect the GPIO
> controller you depends on: instead of linking this information to the
> usba compatible string you could link it to the gpio controller
> compatible string.
>
> You can find the gpio controller node thanks to your "vbus-gpio"
> property: use the phandle defined in this property to find the gpio
> controller node, and once you have the device_node referencing the gpio
> controller you can match it with your internal device_id table
> (containing 2 entries: one for the at91rm9200 IP and the other for the
> at91sam9x5 IP).
I have a working PoC for that if this is the chosen solution.
> Another solution would be to add an irq_try_set_irq_type function that
> would not complain when it fails to set the requested trigger.
>
> Thomas, I know you did not follow the whole thread, but would you mind
> adding this irq_try_set_irq_type function (here is a reference
> implementation [1]), to prevent this error trace from happening when
> we're just trying a configuration ?
This would be great :-)
> > If not, I am ok to drop the feature, this is only a bonus.
>
> That could be a short term solution, to get this series accepted. We
> could then find a proper way to support that optimization.
I agree, I have the feeling your proposed core change may takes a long
time, I just sent a v7 without IRQ single edge support.
Sylvain
next prev parent reply other threads:[~2015-02-12 18:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 16:56 [PATCHv6 0/5] USB: gadget: atmel_usba_udc: Driver improvements Sylvain Rochet
2015-01-22 16:56 ` [PATCHv6 1/5] USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state Sylvain Rochet
2015-01-22 16:56 ` [PATCHv6 2/5] USB: gadget: atmel_usba_udc: Request an auto disabled Vbus signal IRQ instead of an auto enabled IRQ request followed by IRQ disable Sylvain Rochet
2015-01-23 7:43 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-23 8:59 ` Nicolas Ferre
2015-01-23 9:39 ` Sylvain Rochet
2015-02-05 11:28 ` Nicolas Ferre
2015-01-22 16:56 ` [PATCHv6 3/5] USB: gadget: atmel_usba_udc: Start clocks on rising edge of the Vbus signal, stop clocks on falling edge of the Vbus signal Sylvain Rochet
2015-01-22 16:56 ` [PATCHv6 4/5] USB: gadget: atmel_usba_udc: Prepare for IRQ single edge support Sylvain Rochet
2015-01-22 17:14 ` Boris Brezillon
2015-02-05 17:19 ` Nicolas Ferre
2015-02-07 19:37 ` Sylvain Rochet
2015-02-08 9:24 ` Boris Brezillon
2015-02-12 18:00 ` Sylvain Rochet [this message]
2015-01-22 16:56 ` [PATCHv6 5/5] USB: gadget: atmel_usba_udc: Add suspend/resume with wakeup support Sylvain Rochet
2015-02-05 17:20 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212180029.GA8756@gradator.net \
--to=sylvain.rochet@finsecur$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox