From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT
Date: Mon, 23 Feb 2015 14:42:47 +0100 [thread overview]
Message-ID: <20150223134247.GC23581@lunn.ch> (raw)
In-Reply-To: <1424696334-14767-1-git-send-email-simon.guinot@sequanux.org>
On Mon, Feb 23, 2015 at 01:58:54PM +0100, Simon Guinot wrote:
> On some boards, such as the LaCie 2Big Network v2 or 2Big NAS (based on
> Marvell Kirkwood SoCs), an I2C fan controller is used but the alarm
> signal is wired to a separate GPIO. Unfortunately, the gpio-fan driver
> can't be used to handle GPIO alarm alone from DT: an error is returned
> if the "gpios" DT property is missing.
>
> This patch allows to use the gpio-fan driver even if the "alarm-gpios"
> DT property is defined alone.
>
> Signed-off-by: Simon Guinot <simon.guinot@sequanux•org>
> ---
> .../devicetree/bindings/gpio/gpio-fan.txt | 6 ++-
> drivers/hwmon/gpio-fan.c | 44 +++++++++++-----------
> 2 files changed, 27 insertions(+), 23 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-fan.txt b/Documentation/devicetree/bindings/gpio/gpio-fan.txt
> index 2dd457a3469a..a4c5d15b72e6 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-fan.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-fan.txt
> @@ -2,16 +2,18 @@ Bindings for fan connected to GPIO lines
>
> Required properties:
> - compatible : "gpio-fan"
> +
> +Optional properties:
> - gpios: Specifies the pins that map to bits in the control value,
> ordered MSB-->LSB.
> - gpio-fan,speed-map: A mapping of possible fan RPM speeds and the
> control value that should be set to achieve them. This array
> must have the RPM values in ascending order.
> -
> -Optional properties:
> - alarm-gpios: This pin going active indicates something is wrong with
> the fan, and a udev event will be fired.
>
> +Note: At least one the "gpios" and "alarm-gpios" properties should be set.
I think you have this sentence wrong. What i think you mean is
Note: At least one of "gpios" or "alarm-gpios" properties should be set.
Andrew
next prev parent reply other threads:[~2015-02-23 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 12:58 [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT Simon Guinot
2015-02-23 13:42 ` Andrew Lunn [this message]
2015-02-23 14:06 ` Guenter Roeck
2015-02-23 14:34 ` Simon Guinot
2015-02-23 14:43 ` Guenter Roeck
2015-02-25 11:14 ` Simon Guinot
2015-02-25 13:50 ` Andrew Lunn
2015-02-25 14:29 ` Simon Guinot
2015-02-25 14:52 ` Guenter Roeck
2015-02-25 14:51 ` Guenter Roeck
2015-02-25 15:04 ` Andrew Lunn
2015-02-25 16:20 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223134247.GC23581@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox