From: gregkh@linuxfoundation•org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/5] USB: ehci-atmel: rework clk handling
Date: Wed, 18 Mar 2015 13:28:54 +0100 [thread overview]
Message-ID: <20150318122854.GA18070@kroah.com> (raw)
In-Reply-To: <55095E86.1060201@atmel.com>
On Wed, Mar 18, 2015 at 12:16:22PM +0100, Nicolas Ferre wrote:
> Le 17/03/2015 20:01, Alan Stern a ?crit :
> > On Tue, 17 Mar 2015, Boris Brezillon wrote:
> >
> >> The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk)
> >> clocks to work properly. Remove the useless system clock (fclk).
> >>
> >> Avoid calling set_rate on the fixed rate UTMI/IPLL clock and remove
> >> useless IS_ENABLED(CONFIG_COMMON_CLK) tests (all at91 platforms have been
> >> moved to the CCF).
> >>
> >> This patch also fixes a bug introduced by 3440ef1 (ARM: at91/dt: fix USB
> >> high-speed clock to select UTMI), which was leaving the usb clock
> >> uninitialized and preventing the OHCI driver from setting the usb clock
> >> rate to 48MHz.
> >> This bug was caused by several things:
> >> 1/ usb clock drivers set the CLK_SET_RATE_GATE flag, which means the rate
> >> cannot be changed once the clock is prepared
> >> 2/ The EHCI driver was retrieving and preparing/enabling the uhpck
> >> clock which was in turn preparing its parent clock (the usb clock),
> >> thus preventing any rate change because of 1/
> >>
> >> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons•com>
> >
> > Acked-by: Alan Stern <stern@rowland•harvard.edu>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>
> and:
> Fixes: 3440ef169100 ("ARM: at91/dt: fix USB high-speed clock to select UTMI")
>
> Alan, Greg,
>
> Can you please take this patch (only this patch 1/5 of the series) as a fix
> for the 4.0-rc? It would solve the issue that we see on at91sam9x5/at91sam9n12.
> I'll take care of the rest of the series for 4.1.
>
> If you want me to take it of to re-send the patch, tell me.
I'll queue it up now, thanks. You can take the rest of the series :)
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-18 12:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 16:15 [PATCH 0/5] USB: atmel: rework clock handling Boris Brezillon
2015-03-17 16:15 ` [PATCH 1/5] USB: ehci-atmel: rework clk handling Boris Brezillon
2015-03-17 19:01 ` Alan Stern
2015-03-18 11:16 ` Nicolas Ferre
2015-03-18 12:28 ` Greg Kroah-Hartman [this message]
2015-03-18 19:39 ` Douglas Gilbert
2015-03-17 16:15 ` [PATCH 2/5] USB: host: ohci-at91: remove useless uclk clock Boris Brezillon
2015-03-17 19:02 ` Alan Stern
2015-03-23 15:55 ` Nicolas Ferre
2015-03-23 17:23 ` Alan Stern
2015-03-17 16:15 ` [PATCH 3/5] USB: atmel: update DT bindings documentation Boris Brezillon
2015-03-17 16:15 ` [PATCH 4/5] ARM: at91/dt: remove useless uhpck clock references from ehci defintions Boris Brezillon
2015-03-17 16:15 ` [PATCH 5/5] ARM: at91/dt: remove useless usb clock Boris Brezillon
2015-05-22 9:15 ` [PATCH 0/5] USB: atmel: rework clock handling Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318122854.GA18070@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox