From: thomas.petazzoni@free-electrons•com (Thomas Petazzoni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] PCI: mvebu: add suspend/resume support
Date: Thu, 19 Mar 2015 09:24:46 +0100 [thread overview]
Message-ID: <20150319092446.468ab397@free-electrons.com> (raw)
In-Reply-To: <20150317151501.GC3368@io.lakedaemon.net>
Dear Jason Cooper,
On Tue, 17 Mar 2015 15:15:01 +0000, Jason Cooper wrote:
> > diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
> > index 1309cfb..1ab8635 100644
> > --- a/drivers/pci/host/pci-mvebu.c
> > +++ b/drivers/pci/host/pci-mvebu.c
> > @@ -129,6 +129,7 @@ struct mvebu_pcie_port {
> > size_t memwin_size;
> > phys_addr_t iowin_base;
> > size_t iowin_size;
> > + u32 saved_pcie_stat;
>
> nit: It's already in the pcie port struct, why not just call it saved_state?
Well the "stat" does not mean "state", but refers to the register being
saved in this field. The register is called: PCIE_STAT_OFF. Hence the
name saved_pcie_stat. But I'm fine with changing this to some other
name, I really don't care :)
> Either way,
>
> Acked-by: Jason Cooper <jason@lakedaemon•net>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-19 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 14:55 [PATCH] PCI: mvebu: add suspend/resume support Thomas Petazzoni
2015-03-17 15:15 ` Jason Cooper
2015-03-19 8:24 ` Thomas Petazzoni [this message]
2015-03-20 23:27 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319092446.468ab397@free-electrons.com \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox