From: vinod.koul@intel•com (Vinod Koul)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers
Date: Mon, 30 Mar 2015 23:18:27 +0530 [thread overview]
Message-ID: <20150330174827.GL7192@intel.com> (raw)
In-Reply-To: <1427456155-28990-2-git-send-email-peter.ujfalusi@ti.com>
On Fri, Mar 27, 2015 at 01:35:51PM +0200, Peter Ujfalusi wrote:
> From: Petr Kulhavy <petr@barix•com>
>
> If edma_terminate_all() was called while a transfer was running (i.e. after
> edma_execute() but before edma_callback()) the echan->edesc was not freed.
>
> This was due to the fact that a running transfer is on none of the
> vchan lists: desc_submitted, desc_issued, desc_completed (edma_execute()
> removes it from the desc_issued list), so the vchan_dma_desc_free_list()
> called at the end of edma_terminate_all() didn't find it and didn't free it.
>
> This bug was found on an AM1808 based hardware (very similar to da850evm,
> however using the second MMC/SD controller), where intense operations on the SD
> card wasted the device 128MB RAM within a couple of days.
>
> Peter Ujfalusi:
> The issue is even more severe since it affects cyclic (audio) transfers as
> well. In this case starting/stopping audio will results memory leak.
>
> Signed-off-by: Petr Kulhavy <petr@barix•com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti•com>
> CC: <stable@vger•kernel.org>
> CC: <linux-omap@vger•kernel.org>
Applied, thanks
--
~Vinod
> ---
> drivers/dma/edma.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 741baa68365c..984c2b12dae3 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -268,6 +268,13 @@ static int edma_terminate_all(struct dma_chan *chan)
> */
> if (echan->edesc) {
> int cyclic = echan->edesc->cyclic;
> +
> + /*
> + * free the running request descriptor
> + * since it is not in any of the vdesc lists
> + */
> + edma_desc_free(&echan->edesc->vdesc);
> +
> echan->edesc = NULL;
> edma_stop(echan->ch_num);
> /* Move the cyclic channel back to default queue */
> --
> 2.3.3
>
--
next prev parent reply other threads:[~2015-03-30 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 11:35 [PATCH 0/5] dmaengine: Fix memory leak amongs virt-dma users Peter Ujfalusi
2015-03-27 11:35 ` [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul [this message]
2015-03-27 11:35 ` [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a " Peter Ujfalusi
2015-03-28 3:57 ` Stephen Warren
2015-03-28 21:50 ` Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 4/5] dmaengine: hsu: " Peter Ujfalusi
2015-03-27 12:01 ` Andy Shevchenko
2015-03-30 17:37 ` Vinod Koul
2015-04-28 11:17 ` 'Greg Kroah-Hartman'
2015-05-04 11:04 ` Vinod Koul
2015-05-07 16:26 ` Andy Shevchenko
2015-03-27 11:35 ` [PATCH 5/5] dmaengine: moxart-dma: " Peter Ujfalusi
2015-03-30 17:49 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330174827.GL7192@intel.com \
--to=vinod.koul@intel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox