From: gregkh@linuxfoundation•org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index
Date: Tue, 14 Apr 2015 15:27:45 +0200 [thread overview]
Message-ID: <20150414132745.GA5650@kroah.com> (raw)
In-Reply-To: <2433709.D3gBAte9Iu@wuerfel>
On Tue, Apr 14, 2015 at 03:17:30PM +0200, Arnd Bergmann wrote:
> On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote:
> > On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote:
> > > This is true, but all other drivers do the same for GENERIC_PHY at the
> > > moment. If this one gets changed, we should probably apply the same
> > > solution to all current users and fix them consistently.
> > >
> > > We can do one of these two:
> > >
> > > a) make sure that the framework has 'static inline' stubs that let you
> > > build all drivers using it when the framework itself is disabled.
> >
> > Yes, please do that.
> >
> > > b) change the drivers using it to 'depends on', and make GENERIC_PHY
> > > itself a hidden option without a Kconfig prompt.
> >
> > Then how could GENERIC_PHY ever get set?
>
> Right now, every driver that provides a phy uses 'select GENERIC_PHY',
> and they would have to keep doing that. This is not unlike what we
> do for other silent symbols like MFD_CORE, REGMAP_I2C, or PINCTRL,
> and it's not as problematic as 'select' on a user-visible option,
> or (worst) mixing 'select' and 'depends on'.
Ok, that would make more sense, but it would be good for the PHY
maintainer to agree to it as well :)
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-14 13:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 22:10 [PATCHv2 0/3] Add devm_of_phy_get_by_index and update platform drivers Arun Ramamurthy
2015-04-13 22:10 ` [PATCHv2 1/3] phy: core: Add devm_of_phy_get_by_index to phy-core Arun Ramamurthy
2015-04-15 9:59 ` Kishon Vijay Abraham I
2015-04-20 20:19 ` Arun Ramamurthy
2015-04-21 5:37 ` Kishon Vijay Abraham I
2015-04-16 7:08 ` Peter Chen
2015-04-13 22:10 ` [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index Arun Ramamurthy
2015-04-14 11:19 ` Greg Kroah-Hartman
2015-04-14 11:33 ` Arnd Bergmann
2015-04-14 12:37 ` Greg Kroah-Hartman
2015-04-14 13:17 ` Arnd Bergmann
2015-04-14 13:27 ` Greg Kroah-Hartman [this message]
2015-04-14 14:21 ` Kishon Vijay Abraham I
2015-04-14 18:05 ` Arun Ramamurthy
2015-04-14 21:47 ` Arnd Bergmann
2015-04-21 5:32 ` Kishon Vijay Abraham I
2015-04-14 14:23 ` Kishon Vijay Abraham I
2015-04-14 14:41 ` Alan Stern
2015-04-14 17:54 ` Arun Ramamurthy
2015-04-15 9:57 ` rajeev kumar
2015-04-15 14:36 ` Alan Stern
2015-04-16 4:55 ` rajeev kumar
2015-04-13 22:10 ` [PATCHv2 3/3] usb: ohci-platform: " Arun Ramamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414132745.GA5650@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox