From: alexandre.belloni@free-electrons•com (Alexandre Belloni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/7] rtc: arm: imx: snvs: change use syscon to access register
Date: Sat, 16 May 2015 16:04:22 +0200 [thread overview]
Message-ID: <20150516140422.GL3338@piout.net> (raw)
In-Reply-To: <1431696990-23078-3-git-send-email-Frank.Li@freescale.com>
Hi,
On 15/05/2015 at 21:36:25 +0800, Frank.Li at freescale.com wrote :
> From: Frank Li <Frank.Li@freescale•com>
>
> snvs included rtc, on/off key, power-off module
> change to syscon to access register
>
> Signed-off-by: Frank Li <Frank.Li@freescale•com>
> ---
> drivers/rtc/rtc-snvs.c | 124 +++++++++++++++++++++----------------------------
> 1 file changed, 54 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c
> index 0479e80..4e85fbe 100644
> --- a/drivers/rtc/rtc-snvs.c
> +++ b/drivers/rtc/rtc-snvs.c
> @@ -18,14 +18,16 @@
> #include <linux/platform_device.h>
> #include <linux/rtc.h>
> #include <linux/clk.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/regmap.h>
>
> /* These register offsets are relative to LP (Low Power) range */
Shouldn't you remove that comment ?
> -#define SNVS_LPCR 0x04
> -#define SNVS_LPSR 0x18
> -#define SNVS_LPSRTCMR 0x1c
> -#define SNVS_LPSRTCLR 0x20
> -#define SNVS_LPTAR 0x24
> -#define SNVS_LPPGDR 0x30
> +#define SNVS_LPCR 0x38
> +#define SNVS_LPSR 0x4c
> +#define SNVS_LPSRTCMR 0x50
> +#define SNVS_LPSRTCLR 0x54
> +#define SNVS_LPTAR 0x58
> +#define SNVS_LPPGDR 0x64
>
> #define SNVS_LPCR_SRTC_ENV (1 << 0)
> #define SNVS_LPCR_LPTA_EN (1 << 1)
> @@ -37,31 +39,35 @@
>
> struct snvs_rtc_data {
> struct rtc_device *rtc;
> - void __iomem *ioaddr;
> + struct regmap *snvs;
> int irq;
> spinlock_t lock;
This lock can probably be removed, if I'm not mistaken the only use left
is its initialization.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-16 14:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 13:36 [PATCH resend 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver Frank.Li at freescale.com
2015-05-15 13:36 ` [PATCH 1/7] arm: imx: power-off: change to syscon to access register Frank.Li at freescale.com
2015-05-16 13:54 ` Alexandre Belloni
2015-05-15 13:36 ` [PATCH 2/7] rtc: arm: imx: snvs: change use " Frank.Li at freescale.com
2015-05-16 14:04 ` Alexandre Belloni [this message]
2015-05-15 13:36 ` [PATCH 3/7] Document: dt: fsl: snvs: change support syscon Frank.Li at freescale.com
2015-05-15 13:36 ` [PATCH 4/7] arm: dts: imx: update snvs to use syscon access register Frank.Li at freescale.com
2015-05-18 8:45 ` Philipp Zabel
2015-05-18 19:30 ` Zhi Li
2015-05-18 22:17 ` Alexandre Belloni
2015-05-15 13:36 ` [PATCH 5/7] input: keyboard: imx: add snvs power key driver Frank.Li at freescale.com
2015-05-15 18:27 ` Dmitry Torokhov
2015-05-15 13:36 ` [PATCH 6/7] document: devicetree: input: imx: i.mx snvs power device tree bindings Frank.Li at freescale.com
2015-05-15 13:36 ` [PATCH 7/7] arm: dts: imx6sx: enable snvs power key Frank.Li at freescale.com
2015-05-15 18:28 ` [PATCH resend 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2015-05-14 17:18 [PATCH " Frank.Li at freescale.com
2015-05-14 17:18 ` [PATCH 2/7] rtc: arm: imx: snvs: change use syscon to access register Frank.Li at freescale.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150516140422.GL3338@piout.net \
--to=alexandre.belloni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox