From: sboyd@codeaurora•org (Stephen Boyd)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype
Date: Tue, 19 May 2015 18:01:44 -0700 [thread overview]
Message-ID: <20150520010144.GA31054@codeaurora.org> (raw)
In-Reply-To: <5557267D.7080209@kapsi.fi>
On 05/16, Mikko Perttunen wrote:
> On 05/15/2015 06:40 PM, Boris Brezillon wrote:
> >Hi Stephen,
> >
> >Adding Mikko in the loop (after all, he was the one complaining about
> >this signed long limitation in the first place, and I forgot to add
> >him in the Cc list :-/).
>
> I think I got it through linux-tegra anyway, but thanks :)
>
> >
> >Mikko, are you okay with the approach proposed by Stephen (adding a
> >new method) ?
>
> Yes, sounds good to me. If a driver uses the existing methods with
> too large frequencies, the issue is pretty discoverable anyway. I
> think "adjust_rate" sounds a bit too much like it sets the clock's
> rate, though; perhaps "adjust_rate_request" or something like that?
>
Well I'm also OK with changing the determine_rate API one more
time, but we'll have to be careful. Invariably someone will push
a new clock driver through some non-clk tree path and we'll get
build breakage. They shouldn't be doing that, so either we do the
change now and push it to -next and see what breaks, or we do
this after -rc1 comes out and make sure everyone has lots of
warning.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-20 1:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 15:30 [PATCH v2 0/2] clk: adapt ->round_rate()/->determine_rate() prototypes Boris Brezillon
2015-04-30 15:30 ` [PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype Boris Brezillon
2015-05-07 6:39 ` Stephen Boyd
2015-05-07 7:37 ` Boris Brezillon
2015-05-15 15:40 ` Boris Brezillon
2015-05-16 11:14 ` Mikko Perttunen
2015-05-20 1:01 ` Stephen Boyd [this message]
2015-06-04 23:02 ` Paul Walmsley
2015-06-05 8:46 ` Jon Hunter
2015-06-05 11:39 ` Boris Brezillon
2015-06-08 8:46 ` Jon Hunter
[not found] ` <20150610030254.6017.98627@quantum>
2015-06-10 7:00 ` Boris Brezillon
2015-06-05 11:38 ` Boris Brezillon
2015-04-30 15:30 ` [PATCH v2 2/2] clk: change clk_ops' ->determine_rate() prototype Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520010144.GA31054@codeaurora.org \
--to=sboyd@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox