From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep
Date: Mon, 1 Jun 2015 10:12:09 -0700 [thread overview]
Message-ID: <20150601171209.GW30984@atomide.com> (raw)
In-Reply-To: <CAOCHtYigGmDY6c8woQxwdy9kU0J1h258jZXL7g7=VdrxKJC9cA@mail.gmail.com>
* Robert Nelson <robertcnelson@gmail•com> [150531 19:20]:
> On Sun, May 31, 2015 at 7:20 PM, Matthijs van Duin
> <matthijsvanduin@gmail•com> wrote:
> > Sorry for the late response, I only just noticed this since I wasn't CC'd.
> >
> > This "fix" was not ever Reported-By or Tested-By me as it claims. It
> > is in fact wrong: &rtc { system-power-controller; } needs to be
> > present for every variety of beaglebone (more generally every design
> > with a TPS65217 whose PWR_EN is connected to the PMIC_POWER_EN pin of
> > an AM335x).
> >
> > Without a system-power-controller, the kernel has no way of turning
> > off the system and shutdown will leave the system halted instead.
> >
> > The previously posted fix, which added &tps {
> > ti,pmic-shutdown-controller; } was correct, and ensures that a
> > poweroff makes the pmic enter "OFF-state" rather than "SLEEP-state"
> > (aka RTC-only sleep).
>
> Sorry Matthijs, (and everyone else)
>
> That's my fault for completely screwing up this patch..
Hmm OK. So do we now have a situation in the mainline that can
potentially cause hardware damage?
It seems we don't need to revert anything, just apply Matthijs'
new patch?
Regards,
Tony
prev parent reply other threads:[~2015-06-01 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:38 [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep Robert Nelson
2015-05-20 16:47 ` Tony Lindgren
2015-06-01 0:20 ` Matthijs van Duin
2015-06-01 2:18 ` Robert Nelson
2015-06-01 5:14 ` Matthijs van Duin
2015-06-01 17:23 ` Tony Lindgren
2015-06-01 19:33 ` Matthijs van Duin
2015-06-01 20:01 ` Tony Lindgren
2015-06-11 14:18 ` [PATCH] Revert "ARM: dts: am335x-boneblack: disable RTC-only sleep" Johan Hovold
2015-07-06 12:16 ` Tony Lindgren
2015-06-01 17:12 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601171209.GW30984@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox