From: thierry.reding@gmail•com (Thierry Reding)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] dt-bindings: pwm: add MediaTek display PWM bindings
Date: Fri, 12 Jun 2015 12:23:45 +0200 [thread overview]
Message-ID: <20150612102344.GG19400@ulmo.nvidia.com> (raw)
In-Reply-To: <1432214964-40644-2-git-send-email-yh.huang@mediatek.com>
On Thu, May 21, 2015 at 09:29:23PM +0800, YH Huang wrote:
> Document the device-tree binding of MediatTek display PWM.
s/MediatTek/MediaTek/
>
> Signed-off-by: YH Huang <yh.huang@mediatek•com>
This could use a more verbose commit message. You could mention what the
PWM is typically used for (display I presume). Perhaps mention how many
channels it exposes and so on.
> ---
> .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 25 ++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> new file mode 100644
> index 0000000..f55bf92
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> @@ -0,0 +1,25 @@
> +MediaTek display PWM controller
> +
> +Required properties:
> + - compatible: should be "mediatek,<name>-disp-pwm"
> + - "mediatek,mt8173-disp-pwm": found on mt8173 SoC
> + - "mediatek,mt6595-disp-pwm": found on mt6595 SoC
> + - reg: physical base address and length of the controller's registers
> + - #pwm-cells: must be 2. See pwm.txt in this directory
> + for a description of the cell format
You can use the full line width of 78/80 characters, no need to wrap
this prematurely.
> + - clocks: phandle and clock specifier of the PWM reference clock
> + - clock-names: must contain the following
> + - "main": clock used to generate PWM signals
> + - "mm": sync signals from the modules of mmsys
> +
> +Example:
> + pwm0: pwm at 1401e000 {
> + compatible = "mediatek,mt8173-disp-pwm",
> + "mediatek,mt6595-disp-pwm";
> + reg = <0 0x1401e000 0 0x1000>;
> + #pwm-cells = <2>;
> + clocks = <&mmsys MM_DISP_PWM026M>,
> + <&mmsys MM_DISP_PWM0MM>;
> + clock-names = "main",
> + "mm";
No need to waste a line,
clock-names = "main", "mm";
fits on a single line just fine.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150612/79af9214/attachment-0001.sig>
next prev parent reply other threads:[~2015-06-12 10:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 13:29 [PATCH v2 0/2] Add MediaTek display PWM driver YH Huang
2015-05-21 13:29 ` [PATCH v2 1/2] dt-bindings: pwm: add MediaTek display PWM bindings YH Huang
2015-06-12 10:23 ` Thierry Reding [this message]
2015-06-18 9:00 ` YH Huang
2015-05-21 13:29 ` [PATCH v2 2/2] pwm: add MediaTek display PWM driver support YH Huang
2015-06-12 10:20 ` Thierry Reding
2015-06-18 10:19 ` YH Huang
2015-06-18 13:58 ` Yingjoe Chen
2015-06-29 9:27 ` Thierry Reding
2015-06-29 9:21 ` Thierry Reding
2015-06-12 10:25 ` Thierry Reding
2015-06-18 9:02 ` YH Huang
2015-05-25 2:14 ` [PATCH v2 0/2] Add MediaTek display PWM driver Yingjoe Chen
2015-06-05 6:15 ` YH Huang
2015-06-05 8:39 ` Matthias Brugger
2015-06-05 10:45 ` YH Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612102344.GG19400@ulmo.nvidia.com \
--to=thierry.reding@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox