From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM64: TTY: hvc_dcc: Add support for ARM64 dcc
Date: Mon, 22 Jun 2015 14:12:28 +0100 [thread overview]
Message-ID: <20150622131228.GE1583@arm.com> (raw)
In-Reply-To: <1434751734-2178-1-git-send-email-timur@codeaurora.org>
On Fri, Jun 19, 2015 at 11:08:54PM +0100, Timur Tabi wrote:
> From: Abhimanyu Kapur <abhimany@codeaurora•org>
>
> Add support for debug communications channel based
> hvc console for arm64 cpus.
I still think we should be disabling userspace access to the DCC if the
kernel is using it as its console.
> Signed-off-by: Abhimanyu Kapur <abhimany@codeaurora•org>
> Signed-off-by: Timur Tabi <timur@codeaurora•org>
> ---
> arch/arm64/include/asm/dcc.h | 49 ++++++++++++++++++++++++++++++++++++++++++++
> drivers/tty/hvc/Kconfig | 2 +-
> 2 files changed, 50 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm64/include/asm/dcc.h
>
> diff --git a/arch/arm64/include/asm/dcc.h b/arch/arm64/include/asm/dcc.h
> new file mode 100644
> index 0000000..f038d61
> --- /dev/null
> +++ b/arch/arm64/include/asm/dcc.h
> @@ -0,0 +1,49 @@
> +/* Copyright (c) 2014 The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * A call to __dcc_getchar() or __dcc_putchar() is typically followed by
> + * a call to __dcc_getstatus(). We want to make sure that the CPU does
> + * not speculative read the DCC status before executing the read or write
> + * instruction. That's what the ISBs are for.
> + *
> + * The 'volatile' ensures that the compiler does not cache the status bits,
> + * and instead reads the DCC register every time.
> + */
Missing header guards.
> +#include <asm/barrier.h>
> +
> +static inline u32 __dcc_getstatus(void)
> +{
> + u32 __ret;
> +
> + asm volatile("mrs %0, mdccsr_el0" : "=r" (__ret)
> + : : "cc");
You don't need the "cc" clobber.
Will
next prev parent reply other threads:[~2015-06-22 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 22:08 [PATCH] ARM64: TTY: hvc_dcc: Add support for ARM64 dcc Timur Tabi
2015-06-22 13:12 ` Will Deacon [this message]
2015-06-22 13:16 ` Timur Tabi
2015-06-24 20:11 ` Timur Tabi
2015-06-30 13:51 ` Will Deacon
2015-06-30 13:58 ` Timur Tabi
-- strict thread matches above, loose matches on Subject: below --
2014-06-16 22:29 Abhimanyu Kapur
2014-06-17 9:51 ` Will Deacon
2015-06-05 18:35 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622131228.GE1583@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox