From: alexandre.belloni@free-electrons•com (Alexandre Belloni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] power: reset: at91: add sama5d3 reset function
Date: Fri, 10 Jul 2015 07:56:58 +0200 [thread overview]
Message-ID: <20150710055658.GZ3127@piout.net> (raw)
In-Reply-To: <20150710031438.GA27089@roeck-us.net>
Hi Guenter,
On 09/07/2015 at 20:14:38 -0700, Guenter Roeck wrote :
> > This patch introduces a new compatible string: "atmel,sama5d3-rstc" for the
> > reset driver of sama5d3 and later chips.
> > As in sama5d3 or later chips, we don't have to shutdown the DDR controller
> > before reset. Shutdown the DDR controller before reset is a workaround to
> > avoid DDR signal driving the bus, but since sama5d3 and later chips there is
> > no such a conflict.
> > That means:
> > 1. the sama5d3 reset function only need to write the rstc register and
> > return.
> > 2. for sama5d3, we can remove the code related with DDR controller as we
> > don't use it at all.
> >
> Sorry, I don't get it. Doesn't that mean there are two distinct logical
> changes, which would ask for two separate patches ?
I would agree with Josh and I think that only one patch is needed. There
is only one change, the removal of the workaround for sama5d3 and later.
As the workaround is using a table of compatibles to remap the ram
controller and the one for sama5d3 is not used because it is not needed,
I think it makes sense to remove it in that same patch. The logical
change here is the removal of the workaround.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-10 5:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 10:15 [PATCH 1/2] power: reset: at91: add sama5d3 reset function Josh Wu
2015-07-09 10:15 ` [PATCH 2/2] ARM: at91: sama5/dt: update rstc to correct compatible string Josh Wu
2015-07-09 12:03 ` [PATCH 1/2] power: reset: at91: add sama5d3 reset function Maxime Ripard
2015-07-09 12:46 ` Nicolas Ferre
2015-07-10 3:06 ` Josh Wu
2015-07-10 6:54 ` Maxime Ripard
2015-07-10 7:59 ` Josh Wu
2015-07-09 17:37 ` Guenter Roeck
2015-07-10 1:59 ` Josh Wu
2015-07-10 3:14 ` Guenter Roeck
2015-07-10 3:52 ` Josh Wu
2015-07-10 5:56 ` Alexandre Belloni [this message]
2015-07-10 17:01 ` Guenter
2015-07-10 6:03 ` Alexandre Belloni
2015-07-10 6:58 ` Maxime Ripard
2015-07-10 7:56 ` Josh Wu
2015-07-10 12:09 ` Alexandre Belloni
2015-07-10 12:31 ` Maxime Ripard
2015-07-10 12:46 ` Alexandre Belloni
2015-07-10 16:12 ` Nicolas Ferre
2015-07-13 3:21 ` Josh Wu
2015-07-20 7:52 ` Maxime Ripard
2015-07-20 8:35 ` Josh Wu
2015-07-20 8:38 ` Nicolas Ferre
2015-07-20 8:44 ` Josh Wu
2015-07-20 9:13 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710055658.GZ3127@piout.net \
--to=alexandre.belloni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox