From: mark.rutland@arm•com (Mark Rutland)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] arm64: dts: Add dts files for Marvell Berlin4CT SoC
Date: Tue, 21 Jul 2015 15:34:26 +0100 [thread overview]
Message-ID: <20150721143426.GC10595@leverpostej> (raw)
In-Reply-To: <1437488279-2088-2-git-send-email-jszhang@marvell.com>
Hi,
> +/dts-v1/;
> +
> +/memreserve/ 0x00000000 0x01000000;
What's this reservation for?
Given you're using PSCI I can't see why we'd expect the kernel to map
but not use some memory.
> +
> +#include "berlin4ct.dtsi"
> +
> +/ {
> + model = "MARVELL BG4CT DMP BOARD";
> + compatible = "marvell,berlin4ct-dmp", "marvell,berlin4ct", "marvell,berlin";
> +
> + chosen {
> + bootargs = "earlyprintk";
> + stdout-path = "serial0:115200n8";
> + };
You shouldn't need those bootargs; "earlyprintk" does nothing on arm64.
[...]
> + gic: interrupt-controller at 901000 {
> + compatible = "arm,gic-400";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0x901000 0x1000>,
> + <0x902000 0x1000>,
> + <0x904000 0x2000>,
> + <0x906000 0x2000>;
> + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> + };
> +
I believe the size of the cpu interface (the second reg entry) should be
0x2000, as GICC_DIR is at offset 0x1000.
Otherwise this looks fine.
Thanks,
Mark.
next prev parent reply other threads:[~2015-07-21 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 14:17 [PATCH 0/2] arm64: Add basic support for Marvell Berlin4CT SoC Jisheng Zhang
2015-07-21 14:17 ` [PATCH 1/2] arm64: dts: Add dts files " Jisheng Zhang
2015-07-21 14:34 ` Mark Rutland [this message]
2015-07-21 14:50 ` Jisheng Zhang
2015-07-21 14:56 ` Mark Rutland
2015-07-21 15:03 ` Sudeep Holla
2015-07-21 14:17 ` [PATCH 2/2] arm64: Enable Marvell Berlin SoC family in Kconfig and defconfig Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721143426.GC10595@leverpostej \
--to=mark.rutland@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox