From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 5/6] iommu/mediatek: Add mt8173 IOMMU driver
Date: Tue, 21 Jul 2015 15:59:10 +0100 [thread overview]
Message-ID: <20150721145910.GG31095@arm.com> (raw)
In-Reply-To: <1437037475-9065-6-git-send-email-yong.wu@mediatek.com>
Hi Yong Wu,
On Thu, Jul 16, 2015 at 10:04:34AM +0100, Yong Wu wrote:
> This patch adds support for mediatek m4u (MultiMedia Memory Management
> Unit).
[...]
> +static void mtk_iommu_tlb_flush_all(void *cookie)
> +{
> + struct mtk_iommu_domain *domain = cookie;
> + void __iomem *base;
> +
> + base = domain->data->base;
> + writel(F_INVLD_EN1 | F_INVLD_EN0, base + REG_MMU_INV_SEL);
> + writel(F_ALL_INVLD, base + REG_MMU_INVALIDATE);
This needs to be synchronous, so you probably want to call
mtk_iommu_tlb_sync at the end.
> +}
> +
> +static void mtk_iommu_tlb_add_flush(unsigned long iova, size_t size,
> + bool leaf, void *cookie)
> +{
> + struct mtk_iommu_domain *domain = cookie;
> + void __iomem *base = domain->data->base;
> + unsigned int iova_start = iova, iova_end = iova + size - 1;
> +
> + writel(F_INVLD_EN1 | F_INVLD_EN0, base + REG_MMU_INV_SEL);
> +
> + writel(iova_start, base + REG_MMU_INVLD_START_A);
> + writel(iova_end, base + REG_MMU_INVLD_END_A);
> + writel(F_MMU_INV_RANGE, base + REG_MMU_INVALIDATE);
Why are you using writel instead of writel_relaxed? I asked this before
but I don't think you replied.
Will
next prev parent reply other threads:[~2015-07-21 14:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 9:04 [PATCH v3 0/6] MT8173 IOMMU SUPPORT Yong Wu
2015-07-16 9:04 ` [PATCH v3 1/6] dt-bindings: iommu: Add binding for mediatek IOMMU Yong Wu
2015-07-16 9:04 ` [PATCH v3 2/6] dt-bindings: mediatek: Add smi dts binding Yong Wu
2015-07-16 9:04 ` [PATCH v3 3/6] iommu: add ARM short descriptor page table allocator Yong Wu
2015-07-21 17:11 ` Will Deacon
2015-07-24 5:24 ` Yong Wu
2015-07-24 16:53 ` Will Deacon
2015-07-27 4:21 ` Yong Wu
2015-07-27 14:05 ` Robin Murphy
2015-07-27 14:11 ` Will Deacon
2015-07-28 5:08 ` Yong Wu
2015-07-28 11:00 ` Will Deacon
2015-07-28 13:37 ` Yong Wu
2015-07-28 13:47 ` Will Deacon
[not found] ` <1438329337.25925.147.camel@mhfsdcap03>
2015-07-31 11:32 ` Will Deacon
2015-09-14 12:25 ` Yong Wu
2015-09-16 12:55 ` Will Deacon
2015-09-17 2:38 ` Yong Wu
2015-07-16 9:04 ` [PATCH v3 4/6] memory: mediatek: Add SMI driver Yong Wu
2015-07-16 9:04 ` [PATCH v3 5/6] iommu/mediatek: Add mt8173 IOMMU driver Yong Wu
2015-07-21 14:59 ` Will Deacon [this message]
2015-07-24 5:43 ` Yong Wu
2015-07-24 16:55 ` Will Deacon
2015-07-27 4:24 ` Yong Wu
2015-07-27 15:48 ` Will Deacon
2015-07-27 13:23 ` Robin Murphy
2015-07-27 15:31 ` Russell King - ARM Linux
2015-07-27 15:49 ` Robin Murphy
2015-07-29 5:41 ` Yong Wu
2015-07-29 10:31 ` Will Deacon
2015-07-29 6:32 ` Yong Wu
2015-07-16 9:04 ` [PATCH v3 6/6] dts: mt8173: Add iommu/smi nodes for mt8173 Yong Wu
2015-07-23 14:40 ` Daniel Kurtz
2015-07-29 7:29 ` Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721145910.GG31095@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox