From: bonbons@linux-vserver•org (Bruno Prémont)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-sunxi] [PATCH 6/8] ARM: dts: axp209: Add usb_power_supply child node to the ax209 node
Date: Fri, 31 Jul 2015 07:51:04 +0200 [thread overview]
Message-ID: <20150731075104.48c467e6@pluto.restena.lu> (raw)
In-Reply-To: <CAGb2v66X79dK84hG8NVTho-kPPMNcKXQspvT2pCM8Zbmnme53A@mail.gmail.com>
Hi ChenYu,
On Fri, 31 Jul 2015 13:31:53 +0800 Chen-Yu Tsai wrote:
> Hi Hans,
>
> On Wed, Jun 10, 2015 at 5:37 AM, Hans de Goede <hdegoede@redhat•com> wrote:
> > Add a node representing the usb power supply part of the axp209 pmic, note
> > that the usb power supply and the (to be added later) ac power supply will
> > each have their own child-node, so that they can be separately specified
> > as power-supply for other nodes using a power-supply property with a
> > phandle pointing to the right axp209 child-node.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat•com>
> > ---
> > arch/arm/boot/dts/axp209.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
> > index 24c935c..051ab3b 100644
> > --- a/arch/arm/boot/dts/axp209.dtsi
> > +++ b/arch/arm/boot/dts/axp209.dtsi
> > @@ -89,4 +89,9 @@
> > regulator-name = "ldo5";
> > };
> > };
> > +
> > + usb_power_supply: usb_power_supply {
> > + compatible = "x-powers,axp202-usb-power-supply";
> > + status = "disabled";
>
> Is there any reason to have this disabled by default?
> AFAIK this is not something configurable in hardware,
> and the driver just gives readouts and status updates.
There are some devices that only have 'AC-IN' instead of usb/otg power
(set-top boxes) so having the devices tell what power sources they
have makes sense (otherwise those that have ac-in instead of otg would
have to disable usb_power_supply) and avoids confusion by explicitly
stating presence in device dts.
NB: I should hopefully get my battery supply driver ported this WE,
ac-in/rtc are done, this WE. I'm going to default-off for them as well
(note that for some extra details should be provided in dts).
Bruno
> ChenYu
>
> > + };
> > };
> > --
> > 2.3.6
next prev parent reply other threads:[~2015-07-31 5:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 21:37 [PATCH 0/8] mfd/power/phy: Add support for otg vbus detection via axp pmic Hans de Goede
2015-06-09 21:37 ` [PATCH 1/8] mfd: axp20x: Add missing registers, and mark more registers volatile Hans de Goede
2015-06-10 7:36 ` Lee Jones
2015-06-09 21:37 ` [PATCH 2/8] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs Hans de Goede
2015-06-10 1:19 ` [linux-sunxi] " Chen-Yu Tsai
2015-06-10 7:57 ` Hans de Goede
2015-06-13 13:50 ` Maxime Ripard
2015-06-24 12:18 ` Michal Suchanek
2015-06-10 7:35 ` Lee Jones
2015-06-10 7:36 ` Lee Jones
2015-06-09 21:37 ` [PATCH 3/8] power: Add devm_power_supply_get_by_phandle() helper function Hans de Goede
2015-06-10 14:49 ` Sebastian Reichel
2015-06-09 21:37 ` [PATCH 4/8] power: Add an axp20x-usb-power driver Hans de Goede
2015-06-10 7:29 ` Lee Jones
2015-06-10 9:22 ` Hans de Goede
2015-06-10 9:34 ` Lee Jones
2015-06-09 21:37 ` [PATCH 5/8] phy-sun4i-usb: Add support for monitoring vbus via a power-supply Hans de Goede
2015-06-09 21:37 ` [PATCH 6/8] ARM: dts: axp209: Add usb_power_supply child node to the ax209 node Hans de Goede
2015-07-31 5:31 ` [linux-sunxi] " Chen-Yu Tsai
2015-07-31 5:51 ` Bruno Prémont [this message]
2015-07-31 6:14 ` Chen-Yu Tsai
2015-07-31 6:35 ` Bruno Prémont
2015-07-31 7:57 ` Maxime Ripard
2015-07-31 8:31 ` Hans de Goede
2015-07-31 9:00 ` Chen-Yu Tsai
2015-07-31 9:11 ` Hans de Goede
2015-07-31 10:06 ` Chen-Yu Tsai
2015-07-31 9:14 ` Hans de Goede
2015-06-09 21:38 ` [PATCH 7/8] ARM: dts: sun7i: Add regulator configuration to the bananapi dts file Hans de Goede
2015-06-09 21:38 ` [PATCH 8/8] ARM: dts: sun7i: Enable USB DRC on Bananapi Hans de Goede
2015-06-10 6:15 ` [linux-sunxi] [PATCH 0/8] mfd/power/phy: Add support for otg vbus detection via axp pmic Priit Laes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731075104.48c467e6@pluto.restena.lu \
--to=bonbons@linux-vserver$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox