From: bhelgaas@google•com (Bjorn Helgaas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/3] PCI: generic: remove dependency on hw_pci
Date: Tue, 4 Aug 2015 18:49:56 -0500 [thread overview]
Message-ID: <20150804234956.GF17327@google.com> (raw)
In-Reply-To: <1438721620-15493-1-git-send-email-jchandra@broadcom.com>
On Wed, Aug 05, 2015 at 02:23:38AM +0530, Jayachandran C wrote:
> The current code in pci-host-generic.c uses pci_common_init_dev()
> from arm architecture to do some part of the PCI setup, and this
> prevents it from being used with arm64 architecture.
>
> The part of pci_common_init_dev() that is really needed by
> pci-host-generic.c is very limited and can be done in the same
> file without using hw_pci API of ARM. The ARM platform requires
> a pci_sys_data as sysdata for the PCI bus, this can be handled by
> setting up gen_pci to have a pci_sys_data variable as the first
> element.
>
> Signed-off-by: Jayachandran C <jchandra@broadcom•com>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>
> Tested-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>
> Tested-by: Pavel Fedin <p.fedin@samsung•com>
I applied all three of these to my pci/enumeration branch for v4.3.
I made a few changes, the most important being to call
pcie_bus_configure_settings() before pci_bus_add_devices(), because drivers
may claim devices in pci_bus_add_devices(), and the PCI core shouldn't
touch devices after drivers claim them.
I dropped the acks and tested-by because of that change, but I'll happily
add them back if Lorenzo and Pavel confirm. The patches are here if you
want to review/test them:
https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/enumeration
I'm sure the other patches on that branch will need some tweaks, too, so I
don't have any problem with updating these.
Bjorn
next prev parent reply other threads:[~2015-08-04 23:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 20:53 [PATCH v4 1/3] PCI: generic: remove dependency on hw_pci Jayachandran C
2015-08-04 20:53 ` [PATCH v4 2/3] PCI: Add setup-irq.o when compiling for arm64 Jayachandran C
2015-08-04 20:53 ` [PATCH v4 3/3] PCI: generic: add arm64 support Jayachandran C
2015-08-04 23:49 ` Bjorn Helgaas [this message]
2015-08-05 9:23 ` [PATCH v4 1/3] PCI: generic: remove dependency on hw_pci Will Deacon
2015-08-05 9:25 ` Will Deacon
2015-08-05 11:51 ` Bjorn Helgaas
2015-08-13 13:16 ` Suravee Suthikulpanit
2015-08-12 7:11 ` Pavel Fedin
2015-08-12 9:04 ` Will Deacon
2015-08-14 13:44 ` Pavel Fedin
2015-08-14 14:46 ` Bjorn Helgaas
2015-08-14 15:24 ` Lorenzo Pieralisi
2015-08-12 9:15 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804234956.GF17327@google.com \
--to=bhelgaas@google$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox