From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: Add __exception_irq_entry definition for function graph
Date: Wed, 12 Aug 2015 16:02:32 +0100 [thread overview]
Message-ID: <20150812150232.GI23540@arm.com> (raw)
In-Reply-To: <1439388979-1518-1-git-send-email-jungseoklee85@gmail.com>
On Wed, Aug 12, 2015 at 03:16:19PM +0100, Jungseok Lee wrote:
> The gic_handle_irq() is defined with __exception_irq_entry attribute.
> A single remaining work is to add its definition as ARM did. Below
> shows how function graph data is changed with these hunks.
[...]
> diff --git a/arch/arm64/include/asm/traps.h b/arch/arm64/include/asm/traps.h
> index 232e4ba..0cc2f29 100644
> --- a/arch/arm64/include/asm/traps.h
> +++ b/arch/arm64/include/asm/traps.h
> @@ -34,13 +34,32 @@ struct undef_hook {
> void register_undef_hook(struct undef_hook *hook);
> void unregister_undef_hook(struct undef_hook *hook);
>
> +#ifdef CONFIG_FUNCTION_GRAPH_TRACER
> +static inline int __in_irqentry_text(unsigned long ptr)
> +{
> + extern char __irqentry_text_start[];
> + extern char __irqentry_text_end[];
> +
> + return ptr >= (unsigned long)&__irqentry_text_start &&
> + ptr < (unsigned long)&__irqentry_text_end;
> +}
> +#else
> +static inline int __in_irqentry_text(unsigned long ptr)
> +{
> + return 0;
> +}
> +#endif
> +
> static inline int in_exception_text(unsigned long ptr)
> {
> extern char __exception_text_start[];
> extern char __exception_text_end[];
> + int in;
> +
> + in = ptr >= (unsigned long)&__exception_text_start &&
> + ptr < (unsigned long)&__exception_text_end;
>
> - return ptr >= (unsigned long)&__exception_text_start &&
> - ptr < (unsigned long)&__exception_text_end;
> + return in ? : __in_irqentry_text(ptr);
> }
On arm64, this function is only called from dump_backtrace, so I'm
struggling to see why this change makes any difference to the ftrace
output.
What am I missing?
Will
next prev parent reply other threads:[~2015-08-12 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 14:16 [PATCH] arm64: Add __exception_irq_entry definition for function graph Jungseok Lee
2015-08-12 15:02 ` Will Deacon [this message]
2015-08-12 15:18 ` Jungseok Lee
2015-08-12 16:53 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812150232.GI23540@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox