From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 1/5] arm/arm64: add smccc ARCH32
Date: Wed, 19 Aug 2015 17:50:09 +0100 [thread overview]
Message-ID: <20150819165009.GC10297@arm.com> (raw)
In-Reply-To: <1439973629-19505-2-git-send-email-jens.wiklander@linaro.org>
On Wed, Aug 19, 2015 at 09:40:25AM +0100, Jens Wiklander wrote:
> Adds helpers to do SMC based on ARM SMC Calling Convention.
> CONFIG_HAVE_SMCCC is enabled for architectures that may support
> the SMC instruction. It's the responsibility of the caller to
> know if the SMC instruction is supported by the platform.
[...]
> diff --git a/arch/arm64/kernel/smccc-call.S b/arch/arm64/kernel/smccc-call.S
> new file mode 100644
> index 0000000..3ce7fe8
> --- /dev/null
> +++ b/arch/arm64/kernel/smccc-call.S
> @@ -0,0 +1,34 @@
> +/*
> + * Copyright (c) 2015, Linaro Limited
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License Version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */
> +#include <linux/linkage.h>
> +
> +#define SMC_PARAM_W0_OFFS 0
> +#define SMC_PARAM_W2_OFFS 8
> +#define SMC_PARAM_W4_OFFS 16
> +#define SMC_PARAM_W6_OFFS 24
> +
> +/* void smccc_call32(struct smccc_param32 *param) */
> +ENTRY(smccc_call32)
> + stp x28, x30, [sp, #-16]!
Why are you saving lr?
> + mov x28, x0
> + ldp w0, w1, [x28, #SMC_PARAM_W0_OFFS]
> + ldp w2, w3, [x28, #SMC_PARAM_W2_OFFS]
> + ldp w4, w5, [x28, #SMC_PARAM_W4_OFFS]
> + ldp w6, w7, [x28, #SMC_PARAM_W6_OFFS]
> + smc #0
> + stp w0, w1, [x28, #SMC_PARAM_W0_OFFS]
> + stp w2, w3, [x28, #SMC_PARAM_W2_OFFS]
> + ldp x28, x30, [sp], #16
> + ret
> +ENDPROC(smccc_call32)
Could we deal with this like we do for PSCI instead? (see
__invoke_psci_fn_smc). We could also then rename psci-call.S to fw-call.S
and stick this in there too.
Will
next prev parent reply other threads:[~2015-08-19 16:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 8:40 [PATCH v5 0/5] generic TEE subsystem Jens Wiklander
2015-08-19 8:40 ` [PATCH v5 1/5] arm/arm64: add smccc ARCH32 Jens Wiklander
2015-08-19 10:56 ` Yury
2015-08-20 7:23 ` Jens Wiklander
2015-08-19 16:50 ` Will Deacon [this message]
2015-08-20 11:35 ` Michal Simek
2015-08-20 11:37 ` Jens Wiklander
2015-08-20 21:30 ` Mark Rutland
2015-08-21 9:24 ` Will Deacon
2015-08-21 11:43 ` Jens Wiklander
2015-09-14 8:30 ` Jens Wiklander
2015-09-15 18:26 ` Will Deacon
2015-09-15 21:05 ` Jens Wiklander
2015-09-16 17:18 ` Will Deacon
2015-08-19 8:40 ` [PATCH v5 2/5] dt/bindings: add bindings for optee Jens Wiklander
2015-09-15 22:37 ` Rob Herring
2015-09-16 7:13 ` Jens Wiklander
2015-08-19 8:40 ` [PATCH v5 3/5] tee: generic TEE subsystem Jens Wiklander
2015-08-19 8:40 ` [PATCH v5 4/5] tee: add OP-TEE driver Jens Wiklander
2015-08-19 8:40 ` [PATCH v5 5/5] Documentation: tee subsystem and op-tee driver Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819165009.GC10297@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox