Subject: [PATCH 2/6] ARM: dts: sunxi: Add dtsi for AXP221 PMIC

From: [email-masked] (Maxime Ripard)
Date: Fri, 28 Aug 2015 22:43:51 +0200

On Sat, Aug 29, 2015 at 12:09:55AM +0800, Chen-Yu Tsai wrote:
> >> +/*
> >> + * AXP221/221s/223 Integrated Power Management Chip
> >> + * http://www.x-powers.com/product/AXP22X.php
> >> + * http://dl.linux-sunxi.org/AXP/AXP221%20Datasheet%20V1.2%2020130326%20.pdf
> >> + */
> >
> > I'm usually not really fond of URLs in the source code and/or the
> > commit logs. They tend to be broken very easily.
> 
> OK. Would you rather I put them in Documentation/arm/sunxi/README?
> It's not immediately clear that sunxi and axp* are connected though.

It's one of the first things that pop up when googling, and it's not
really related to sunxi, so I'd say simply leave them out.

> >> +
> >> +&axp221 {
> >> +     compatible = "x-powers,axp221";
> >> +     interrupt-controller;
> >> +     #interrupt-cells = <1>;
> >> +
> >> +     regulators {
> >> +             /* Default work frequency for buck regulators */
> >> +             x-powers,dcdc-freq = <3000>;
> >> +
> >> +             /* supplies for dc1sw & dc5ldo are connected internally */
> >> +             dcdc1-supply = <&reg_dcdc1>;
> >> +             dcdc5-supply = <&reg_dcdc5>;
> >
> > so the parent regulator of DCDC1 is DCDC1 ?
> 
> These probably aren't the best names. These are the supplies for DC1SW and
> DC5LDO, respectively. They are connected internally, so there aren't named
> pins for them. The comment above explains it, though probably not clearly
> enough. Furthermore, the input pins for DCDC1/5 are VIN1/5.

I'm not quite sure I understand. They're connected internally but they
have pins ?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150828/165096b7/attachment.sig>