From: greg@kroah•com (Greg Kroah-Hartman)
To: linux-arm-kernel@lists•infradead.org
Subject: earlycon issues in -next with amba-pl011 updates
Date: Thu, 3 Sep 2015 08:52:55 -0700 [thread overview]
Message-ID: <20150903155255.GA28336@kroah.com> (raw)
In-Reply-To: <55E81F93.1020104@arm.com>
On Thu, Sep 03, 2015 at 11:23:15AM +0100, Marc Zyngier wrote:
> On 11/08/15 02:48, Jun Nie wrote:
> > 2015-08-11 7:23 GMT+08:00 Leif Lindholm <leif.lindholm@linaro•org>:
> >> Hi all,
> >>
> >> The kernelci.org bot picked up a complete boot failure (no output past
> >> UEFI stub) with next-20150806 and Tyler bisected it down to somewhere
> >> in
> >> 8cd90e5 uart: pl011: Add support to ZTE ZX296702 uart
> >> 09dcc7d uart: pl011: Improve LCRH register access decision
> >> 2c096a9 uart: pl011: Introduce register look up table
> >> 7b753f3 uart: pl011: Introduce register accessor
> >>
> >> The issue only appears with earlycon on command line, for pl011
> >> consoles.
> >>
> >> Some investigation shows that the cause lies with
> >> commit 7b753f318d14 ("uart: pl011: Introduce register accessor")
> >> and
> >> commit 2c096a9eedc6 ("uart: pl011: Introduce register look up table")
> >>
> >> Specifically, the changes to pl011_putc() are incorrect:
> >> The new pl011_ accessors take a (struct uart_amba_port *) input, but
> >> pl011_putc() directly uses the incoming (struct uart_port *) for this.
> >>
> >> Apart from ending up with an unintended/incorrect UART base address,
> >> the introduction of the lookup table for register offsets also means
> >> the accessors try to dereference (struct uart_amba_port *)->reg_lut.
> >>
> >> The below is a hack that shows/resolves the issue, but some
> >> refactoring of the original patches might be in order.
> >>
> >> /
> >> Leif
> >
> > Leif,
> >
> > Sorry for the inconvenience. I do not have idea of early console till
> > now and I always have debug console for early panic debug. Learned
> > more from this issue.
> >
> > Suppose Peter's patch will resolve your issue.
>
> [+ Greg KH]
>
> So -next has now been broken for a while on a number of ARM platforms
> because of this (they simply cannot boot), and no progress has been made
> towards resolving this problem.
>
> Can we please drop this series (at least commits 7b753f3 and following)
> from -next until is has been reworked and reviewed?
I don't have any patches in my -next tree, everything is in Linus's tree
now. So if I've missed something, or need to revert something, please
let me know specifcally what to do.
thanks,
greg k-h
next prev parent reply other threads:[~2015-09-03 15:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 23:23 earlycon issues in -next with amba-pl011 updates Leif Lindholm
2015-08-11 0:31 ` Peter Hurley
2015-08-11 10:07 ` Leif Lindholm
2015-08-11 12:40 ` Russell King - ARM Linux
2015-08-17 16:04 ` Peter Hurley
2015-08-11 1:48 ` Jun Nie
2015-09-03 10:23 ` Marc Zyngier
2015-09-03 15:52 ` Greg Kroah-Hartman [this message]
2015-09-03 16:08 ` Marc Zyngier
2015-09-03 17:49 ` Peter Hurley
2015-09-03 17:53 ` Greg Kroah-Hartman
2015-09-03 18:03 ` Peter Hurley
2015-09-03 18:16 ` Marc Zyngier
2015-09-03 18:21 ` Peter Hurley
2015-09-03 18:00 ` Marc Zyngier
2015-09-03 18:15 ` Peter Hurley
2015-09-04 11:06 ` Will Deacon
2015-09-04 11:13 ` Russell King - ARM Linux
2015-09-05 14:54 ` Jun Nie
2015-09-04 16:15 ` Greg Kroah-Hartman
2015-09-04 16:16 ` Will Deacon
2015-09-05 14:42 ` Jun Nie
2015-09-09 19:54 ` Greg Kroah-Hartman
[not found] ` <CAKU3ayWkXxmF1cp=fOAL6kNKY3wY1u=XhPROKiLqkx4oZ9xZ0g@mail.gmail.com>
2015-09-16 0:54 ` Jun Nie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903155255.GA28336@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox