From: computersforpeace@gmail•com (Brian Norris)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] ARM: brcmstb: Setup BIU control registers during boot
Date: Mon, 14 Sep 2015 13:48:33 -0700 [thread overview]
Message-ID: <20150914204833.GA53555@google.com> (raw)
In-Reply-To: <1442260369-6575-4-git-send-email-f.fainelli@gmail.com>
On Mon, Sep 14, 2015 at 12:52:49PM -0700, Florian Fainelli wrote:
> Call brcmstb_biuctrl_init() in brcmstb's init_irq machine descriptor
> callback since we need to setup the Bus Interface Unit before SMP in
> particular, but we also need to be able to remap registers.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail•com>
> ---
> arch/arm/mach-bcm/brcmstb.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/mach-bcm/brcmstb.c b/arch/arm/mach-bcm/brcmstb.c
> index 3a60f7ee3f0c..99a67cfb7c0d 100644
> --- a/arch/arm/mach-bcm/brcmstb.c
> +++ b/arch/arm/mach-bcm/brcmstb.c
> @@ -12,11 +12,19 @@
> */
>
> #include <linux/init.h>
> +#include <linux/irqchip.h>
> #include <linux/of_platform.h>
> +#include <linux/soc/brcmstb/brcmstb.h>
>
> #include <asm/mach-types.h>
> #include <asm/mach/arch.h>
>
> +static void __init brcmstb_init_irq(void)
> +{
> + irqchip_init();
> + brcmstb_biuctrl_init();
I believe you're introducing a dependency on CONFIG_SOC_BRCMSTB, but
it's not represented in Kconfig. Maybe SOC_BRCMSTB shouldn't be
user-selectable, and it should just be select-ed by ARCH_BRCMSTB?
Brian
> +}
> +
> static const char *const brcmstb_match[] __initconst = {
> "brcm,bcm7445",
> "brcm,brcmstb",
> @@ -25,4 +33,5 @@ static const char *const brcmstb_match[] __initconst = {
>
> DT_MACHINE_START(BRCMSTB, "Broadcom STB (Flattened Device Tree)")
> .dt_compat = brcmstb_match,
> + .init_irq = brcmstb_init_irq,
> MACHINE_END
> --
> 2.1.0
>
next prev parent reply other threads:[~2015-09-14 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 19:52 [PATCH 0/3] ARM: brcmstb: Bus Interface Unit support Florian Fainelli
2015-09-14 19:52 ` [PATCH 1/3] Documentation: bindings: brcmstb: Document write-pairing Florian Fainelli
2015-09-14 20:36 ` Rob Herring
2015-09-14 21:21 ` Florian Fainelli
2015-09-14 19:52 ` [PATCH 2/3] soc: brcmstb: Add Bus Interface Unit control setup Florian Fainelli
2015-09-14 19:52 ` [PATCH 3/3] ARM: brcmstb: Setup BIU control registers during boot Florian Fainelli
2015-09-14 20:48 ` Brian Norris [this message]
2015-09-14 21:21 ` Florian Fainelli
2015-09-14 21:29 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914204833.GA53555@google.com \
--to=computersforpeace@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox