From: computersforpeace@gmail•com (Brian Norris)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mtd: nand: pass page number to ecc->write_xxx() methods
Date: Thu, 1 Oct 2015 09:58:41 -0700 [thread overview]
Message-ID: <20151001165841.GQ143959@google.com> (raw)
In-Reply-To: <20151001170743.3aa0d6fa@bbrezillon>
On Thu, Oct 01, 2015 at 05:07:43PM +0200, Boris Brezillon wrote:
> On Mon, 24 Aug 2015 19:10:19 +0200
> Boris Brezillon <boris.brezillon@free-electrons•com> wrote:
>
> > The ->read_xxx() methods are all passed the page number the NAND controller
> > is supposed to read, but ->write_xxx() do not have such a parameter.
> >
> > This is a problem if we want to properly implement data
> > scrambling/randomization in order to mitigate MLC sensibility to repeated
> > pattern: to prevent bitflips in adjacent pages in the same block we need
> > to avoid repeating the same pattern at the same offset in those pages,
> > hence the randomizer/scrambler engine need to be passed the page value
> > in order to adapt its seed accordingly.
> >
> > Moreover, adding the page parameter the ->write_xxx() methods add some
> > consistency to the current model.
>
> Apparently nobody complained (or nobody cares :-)) about that patch,
> and I'll really need the page information if I want to support
> randomization/scrambling in the sunxi driver.
>
> Do you have any objections to this patch
No, I guess not.
> (I can rebase it on mainline
> and check if new drivers have been added since the submission)?
I recently compile tested it against the tip of tree (don't know why I
didn't merge it then), but I think we added one driver since then. I
suppose a rebase is in order.
> I remember you pointed a trick you've used in the brcmnand driver to
> get this page information (storing it during the ->cmdfunc() or
> ->ctrl_cmd() call), but it would be way easier to have it directly in
> the ecc->write_xxx() parameters...
Right, that's not a pattern I'd really like people to copy...
Regards,
Brian
next prev parent reply other threads:[~2015-10-01 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 17:10 [PATCH] mtd: nand: pass page number to ecc->write_xxx() methods Boris Brezillon
2015-10-01 15:07 ` Boris Brezillon
2015-10-01 16:58 ` Brian Norris [this message]
2015-10-01 17:17 ` Brian Norris
2015-10-01 18:13 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001165841.GQ143959@google.com \
--to=computersforpeace@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox