From: gregkh@linuxfoundation•org (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] sysfs: Support is_visible() on binary attributes
Date: Sun, 4 Oct 2015 19:33:34 +0100 [thread overview]
Message-ID: <20151004183334.GA23538@kroah.com> (raw)
In-Reply-To: <1442842703-5309-2-git-send-email-emilio.lopez@collabora.co.uk>
On Mon, Sep 21, 2015 at 10:38:20AM -0300, Emilio L?pez wrote:
> According to the sysfs header file:
>
> "The returned value will replace static permissions defined in
> struct attribute or struct bin_attribute."
>
> but this isn't the case, as is_visible is only called on struct attribute
> only. This patch introduces a new is_bin_visible() function to implement
> the same functionality for binary attributes, and updates documentation
> accordingly.
>
> Note that to keep functionality and code similar to that of normal
> attributes, the mode is now checked as well to ensure it contains only
> read/write permissions or SYSFS_PREALLOC.
>
> Reviewed-by: Guenter Roeck <linux@roeck-us•net>
> Signed-off-by: Emilio L?pez <emilio.lopez@collabora•co.uk>
As this should probably go through the "platform drivers" maintainer,
I'll just give you this:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
So it can go through their tree and not require me to just take this
one.
thanks,
greg k-h
next prev parent reply other threads:[~2015-10-04 18:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 13:38 [PATCH v3 0/4] platform/chrome: vboot context support Emilio López
2015-09-21 13:38 ` [PATCH 1/4] sysfs: Support is_visible() on binary attributes Emilio López
2015-09-21 13:41 ` Emilio López
2015-10-04 18:33 ` Greg KH [this message]
2015-10-07 22:08 ` Olof Johansson
2015-09-21 13:38 ` [PATCH v3 2/4] Documentation: bindings: mfd: cros ec: document vbc EC property Emilio López
2015-09-21 15:01 ` Javier Martinez Canillas
2015-09-23 0:34 ` Lee Jones
2015-09-23 14:31 ` Emilio López
2015-09-24 17:21 ` Lee Jones
2015-09-21 13:38 ` [PATCH v3 3/4] platform/chrome: Support reading/writing the vboot context Emilio López
2015-10-07 22:08 ` Olof Johansson
2015-09-21 13:38 ` [PATCH v3 4/4] ARM: dts: Enable EC vboot context support on Peach boards Emilio López
2015-10-07 22:31 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004183334.GA23538@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox