From: matt@codeblueprint•co.uk (Matt Fleming)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/9] arm64/efi: refactor EFI init and runtime code for reuse by 32-bit ARM
Date: Sat, 10 Oct 2015 22:00:37 +0100 [thread overview]
Message-ID: <20151010210037.GG2723@codeblueprint.co.uk> (raw)
In-Reply-To: <1443719063-6832-3-git-send-email-ard.biesheuvel@linaro.org>
On Thu, 01 Oct, at 07:04:16PM, Ard Biesheuvel wrote:
> This refactors the EFI init and runtime code that will be shared
> between arm64 and ARM so that it can be built for both archs.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro•org>
> ---
> arch/arm64/include/asm/efi.h | 16 ++++
> arch/arm64/kernel/efi.c | 51 ++++++++++
> drivers/firmware/efi/arm-init.c | 11 ++-
> drivers/firmware/efi/arm-runtime.c | 101 ++++++--------------
> drivers/firmware/efi/efi.c | 4 +-
> 5 files changed, 105 insertions(+), 78 deletions(-)
[...]
> diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
> index 56987a5b9033..235677b86e4e 100644
> --- a/drivers/firmware/efi/arm-init.c
> +++ b/drivers/firmware/efi/arm-init.c
> @@ -66,7 +66,7 @@ static int __init uefi_init(void)
> {
> efi_char16_t *c16;
> void *config_tables;
> - u64 table_size;
> + int table_size;
> char vendor[100] = "unknown";
> int i, retval;
Perhaps 'table_size' should be unsigned long? At the very least it
should be size_t, not int.
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index f5e586bd3b24..2eb31e28a35c 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -23,6 +23,8 @@
> #include <linux/io.h>
> #include <linux/platform_device.h>
>
> +#include <asm/efi.h>
> +
> struct efi __read_mostly efi = {
> .mps = EFI_INVALID_TABLE_ADDR,
> .acpi = EFI_INVALID_TABLE_ADDR,
Hmm... not quite sure why this new include is required?
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-10-10 21:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 17:04 [PATCH 0/9] UEFI boot and runtime services support for 32-bit ARM Ard Biesheuvel
2015-10-01 17:04 ` [PATCH 1/9] arm64/efi: split off EFI init and runtime code for reuse by " Ard Biesheuvel
2015-10-10 20:53 ` Matt Fleming
2015-10-12 7:57 ` Ard Biesheuvel
2015-10-01 17:04 ` [PATCH 2/9] arm64/efi: refactor " Ard Biesheuvel
2015-10-10 21:00 ` Matt Fleming [this message]
2015-11-04 11:44 ` Ard Biesheuvel
2015-10-01 17:04 ` [PATCH 3/9] ARM: add support for generic early_ioremap/early_memremap Ard Biesheuvel
2015-10-01 17:04 ` [PATCH 4/9] ARM: only consider memblocks with NOMAP cleared for linear mapping Ard Biesheuvel
2015-10-01 17:04 ` [PATCH 5/9] ARM: split off core mapping logic from create_mapping Ard Biesheuvel
2015-10-01 17:04 ` [PATCH 6/9] ARM: factor out allocation routine from __create_mapping() Ard Biesheuvel
2015-10-01 17:04 ` [PATCH 7/9] ARM: implement create_mapping_late() for EFI use Ard Biesheuvel
2015-10-01 17:04 ` [PATCH 8/9] ARM: wire up UEFI init and runtime support Ard Biesheuvel
2015-10-01 17:04 ` [PATCH 9/9] ARM: add UEFI stub support Ard Biesheuvel
[not found] ` <CAD0U-h+zPhDe6Fqpg_vhF46FLjvvsbeSrQ_Fnj86o5cRc+A2QQ@mail.gmail.com>
2015-10-02 18:03 ` Ard Biesheuvel
2015-10-02 18:07 ` Ard Biesheuvel
[not found] ` <CAD0U-hK8=65digSpQ8b3zQcx4P3DFayu8eONDsYp9wA4ypPscg@mail.gmail.com>
2015-10-02 19:33 ` Ard Biesheuvel
[not found] ` <CAD0U-hLrY6ZoeT-p6ytmPmwxWcqw0cd3Ax-u0RbEd_Lkj_btUg@mail.gmail.com>
2015-10-05 12:56 ` Ard Biesheuvel
2015-10-02 20:38 ` [PATCH 0/9] UEFI boot and runtime services support for 32-bit ARM Russell King - ARM Linux
2015-10-02 20:49 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151010210037.GG2723@codeblueprint.co.uk \
--to=matt@codeblueprint$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox