From: marex@denx•de (Marek Vasut)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] doc: PCI: altera: Fix the 'ranges' property in example
Date: Mon, 28 Dec 2015 08:34:52 +0100 [thread overview]
Message-ID: <201512280834.52893.marex@denx.de> (raw)
In-Reply-To: <1451285775.2990.2.camel@ubuntu>
On Monday, December 28, 2015 at 07:56:15 AM, Ley Foon Tan wrote:
> On Thu, 2015-12-24 at 10:45 +0100, Marek Vasut wrote:
> > The example does not work on real hardware with the PCIe HIP [1].
> > The problem is with incorrect "ranges" property in the example, so
> > one cannot just copy-paste the example into his DT and expect this
> > to work. This patches aligns the "ranges" in the example with the
> > reference FPGA design.
>
> Hi Marek
Hi Ley,
> The original "ranges" is working for me. What error did you encounter?
Every time a driver accessed the Txs range, the system got stuck hard.
The Cra access always worked fine though, so the PCIe devices were always
detected.
I checked with signaltap and my impression is that the wrong address
propagated into the request passed to the Txs port of the HardIP block,
unless I change the range configuration.
Note that I tested Intel Centrino 6235 WiFi card and Atheros AR5006 WiFi
card. The intel in particular uses both the Txs and even MSI , so to use
the intel, the whole PCIe block has to work properly ; with this change,
it does and I can use the intel card just fine.
> Thanks.
>
> > [1] http://rocketboards.org/foswiki/view/Projects/PCIeRootPortWithMSI
> >
> > Signed-off-by: Marek Vasut <marex@denx•de>
> > Cc: Bjorn Helgaas <bhelgaas@google•com>
> > Cc: Ley Foon Tan <lftan@altera•com>
> > Cc: Marc Zyngier <marc.zyngier@arm•com>
> > Cc: Rob Herring <robh@kernel•org>
> > ---
> >
> > Documentation/devicetree/bindings/pci/altera-pcie.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/altera-pcie.txt
> > b/Documentation/devicetree/bindings/pci/altera-pcie.txt index
> > 2951a6a..d2427c1 100644
> > --- a/Documentation/devicetree/bindings/pci/altera-pcie.txt
> > +++ b/Documentation/devicetree/bindings/pci/altera-pcie.txt
> > @@ -44,6 +44,6 @@ Example
> >
> > <0 0 0 2 &pcie_0 2>,
> > <0 0 0 3 &pcie_0 3>,
> > <0 0 0 4 &pcie_0 4>;
> >
> > - ranges = <0x82000000 0x00000000 0x00000000 0xc0000000 0x00000000
> > 0x10000000 - 0x82000000 0x00000000 0x10000000
0xd0000000
> > 0x00000000 0x10000000>; + ranges = <0x82000000 0x00000000
0xc0000000
> > 0xc0000000 0x00000000 0x10000000 + 0x82000000 0x00000000
0xd0000000
> > 0xd0000000 0x00000000 0x10000000>;
> >
> > };
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-12-28 7:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 9:45 [PATCH] doc: PCI: altera: Fix the 'ranges' property in example Marek Vasut
2015-12-28 6:56 ` Ley Foon Tan
2015-12-28 7:34 ` Marek Vasut [this message]
2015-12-28 7:42 ` Ley Foon Tan
2015-12-28 8:26 ` Marek Vasut
2015-12-29 7:48 ` Ley Foon Tan
2015-12-29 13:33 ` Marek Vasut
2015-12-31 3:09 ` Ley Foon Tan
2015-12-31 9:04 ` Marek Vasut
2016-01-03 23:29 ` Ley Foon Tan
2016-01-03 23:36 ` Marek Vasut
2016-01-04 0:10 ` Ley Foon Tan
2016-01-04 0:37 ` Marek Vasut
2016-01-04 0:53 ` Ley Foon Tan
2016-01-04 1:12 ` Marek Vasut
2016-01-05 0:45 ` Ley Foon Tan
2016-01-05 0:47 ` Marek Vasut
2016-01-05 1:18 ` Ley Foon Tan
2016-01-05 1:53 ` Marek Vasut
2016-01-05 13:49 ` Marek Vasut
2016-01-07 8:56 ` Ley Foon Tan
2016-01-07 16:05 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201512280834.52893.marex@denx.de \
--to=marex@denx$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox