Subject: [PATCHv2 14/18] arm64: mm: use fixmap when creating page tables

From: [email-masked] (Mark Rutland)
Date: Tue, 5 Jan 2016 10:40:23 +0000

Hi,

On Mon, Jan 04, 2016 at 02:38:42PM -0800, Laura Abbott wrote:
> On 01/04/2016 09:56 AM, Mark Rutland wrote:
> >As a prepratory step to allow us to allocate early page tables form
> "page tables from"

Fixed.

> >-#define pud_fixmap_offset(pgd, addr)	pud_fixmap(pmd_offset_phys(pgd, addr))
> >+#define pud_fixmap_offset(pgd, addr)	pud_fixmap(pud_offset_phys(pgd, addr))
> 
> Was this supposed to be folded into a previous patch?

Yes. I've folded that into the prior patch now.

> >-static void *late_pgtable_alloc(void)
> >+static phys_addr_t late_pgtable_alloc(void)
> >  {
> >  	void *ptr = (void *)__get_free_page(PGALLOC_GFP);
> >  	BUG_ON(!ptr);
> >-
> >-	/* Ensure the zeroed page is visible to the page table walker */
> >  	dsb(ishst);
> 
> This dropped the comment but not the actual barrier, was that intentional?

I messed that up when rebasing. Restored now.

Thanks for pointing those out!

Mark.