From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] arm64: insn: remove BUG_ON from codegen
Date: Fri, 15 Jan 2016 17:08:53 +0000 [thread overview]
Message-ID: <20160115170852.GB1641@arm.com> (raw)
In-Reply-To: <1452756802-16511-1-git-send-email-zlim.lnx@gmail.com>
On Wed, Jan 13, 2016 at 11:33:21PM -0800, Zi Shen Lim wrote:
> During code generation, we used to BUG_ON unknown/unsupported encoding
> or invalid parameters.
>
> Instead, now we report these as errors and simply return the
> instruction AARCH64_BREAK_FAULT. Users of these codegen helpers should
> check for and handle this failure condition as appropriate.
>
> Otherwise, unhandled codegen failure will result in trapping at
> run-time due to AARCH64_BREAK_FAULT, which is arguably better than a
> BUG_ON.
>
> Signed-off-by: Zi Shen Lim <zlim.lnx@gmail•com>
> Cc: Will Deacon <will.deacon@arm•com>
> ---
> Per discussion here: http://www.spinics.net/lists/arm-kernel/msg474179.html
Thanks, this looks good to me. Given that Rabin fixes the shift issue
in the core, I'm assuming this can wait until 4.6 and Catalin can queue
it after -rc1?
Acked-by: Will Deacon <will.deacon@arm•com>
Cheers,
Will
next prev parent reply other threads:[~2016-01-15 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 7:33 [PATCH 1/2] arm64: insn: remove BUG_ON from codegen Zi Shen Lim
2016-01-14 7:33 ` [PATCH 2/2] arm64: bpf: add extra pass to handle faulty codegen Zi Shen Lim
2016-01-15 5:09 ` Alexei Starovoitov
2016-01-18 0:15 ` David Miller
2016-01-15 17:08 ` Will Deacon [this message]
2016-01-18 0:15 ` [PATCH 1/2] arm64: insn: remove BUG_ON from codegen David Miller
2016-01-18 0:15 ` David Miller
2016-03-15 4:28 ` 平松雅巳 / HIRAMATU，MASAMI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115170852.GB1641@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox