From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: dts: kirkwood: split lswxl into linkstation lswsxl and lswxl
Date: Tue, 19 Jan 2016 15:48:46 +0100 [thread overview]
Message-ID: <20160119144846.GI6554@lunn.ch> (raw)
In-Reply-To: <CAEQ9gE=saHf0TZ5aBDYC0cCMCXgHOSON8-oPwmVXuU-h4XPbFA@mail.gmail.com>
On Tue, Jan 19, 2016 at 11:15:35PM +0900, Roger Shimizu wrote:
> On Tue, Jan 19, 2016 at 11:05 PM, Andrew Lunn <andrew@lunn•ch> wrote:
> > On Tue, Jan 19, 2016 at 10:49:01PM +0900, Roger Shimizu wrote:
> >> With a few gpio/led-pin changes, including fix for the issue mentioned
> >> in Debian BTS #810894.
> >
> > Hi Roger
> >
> > This fix should be a separate patch. We can then get it applied to
> > stable, so it makes its way back to older kernels.
>
> Dear Andrew,
>
> So this patchset would be reviewed or not?
I will review it and give comments, but won't accept it.
> Or I have to create another patchset including both fix for
> "kirkwood-lswxl.dts" and the dts split?
Yes please. And the fix patch should come first, and have a fixes:
tag.
As a general rule of thumb, it is better to have lots of small, easy
to review patches, than an couple of big patch. So i would probably
have:
1) Fix
2) License change.
3) Split patch LS-WXL/WSXL
4) Split patch LS-WVL/VL
The license change needs a different sort of review to the other
patches, so having it as a separate patch helps with the review
process.
Andrew
next prev parent reply other threads:[~2016-01-19 14:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 13:49 [PATCH 0/2] ARM: dts: kirkwood: split lswxl and lswvl with fixes Roger Shimizu
2016-01-19 13:49 ` [PATCH 1/2] ARM: dts: kirkwood: split lswxl into linkstation lswsxl and lswxl Roger Shimizu
2016-01-19 14:05 ` Andrew Lunn
2016-01-19 14:15 ` Roger Shimizu
2016-01-19 14:48 ` Andrew Lunn [this message]
2016-01-19 14:56 ` Roger Shimizu
2016-01-20 1:08 ` Andrew Lunn
2016-01-19 13:49 ` [PATCH 2/2] ARM: dts: kirkwood: split lswvl into linkstation lsvl and lswvl Roger Shimizu
2016-01-20 15:33 ` [PATCH v2 0/7] ARM: dts: kirkwood: fixes and split of linkstation dts for ls-wvl/vl and ls-wxl/wsxl Roger Shimizu
2016-01-20 15:33 ` [PATCH v2 1/7] ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wxl/wsxl Roger Shimizu
2016-01-20 17:11 ` Andrew Lunn
2016-01-20 15:33 ` [PATCH v2 2/7] ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wvl/vl Roger Shimizu
2016-01-20 17:12 ` Andrew Lunn
2016-01-20 15:33 ` [PATCH v2 3/7] ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wxl/wsxl Roger Shimizu
2016-01-20 17:16 ` Andrew Lunn
2016-01-21 0:16 ` Roger Shimizu
2016-01-21 0:30 ` Andrew Lunn
2016-01-20 15:33 ` [PATCH v2 4/7] ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wvl/vl Roger Shimizu
2016-01-21 0:31 ` Andrew Lunn
2016-01-20 15:33 ` [PATCH v2 5/7] ARM: dts: kirkwood: relicense dts of ls-wvl/vl and ls-wxl/wsxl under GPLv2/X11 Roger Shimizu
2016-01-20 17:18 ` Andrew Lunn
2016-01-20 15:33 ` [PATCH v2 6/7] ARM: dts: kirkwood: split lswxl dts to linkstation lswsxl and lswxl Roger Shimizu
2016-01-20 17:21 ` Sebastian Hesselbarth
2016-01-21 15:06 ` Roger Shimizu
2016-01-21 0:36 ` Andrew Lunn
2016-01-20 15:33 ` [PATCH v2 7/7] ARM: dts: kirkwood: split lswvl dts to linkstation lsvl and lswvl Roger Shimizu
2016-01-21 0:37 ` Andrew Lunn
2016-01-21 14:38 ` [PATCH v3 0/7] ARM: dts: kirkwood: fixes and split of linkstation dts for ls-wvl/vl and ls-wxl/wsxl Roger Shimizu
2016-01-21 14:38 ` [PATCH v3 1/7] ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wxl/wsxl Roger Shimizu
2016-01-21 14:38 ` [PATCH v3 2/7] ARM: dts: kirkwood: gpio pin fixes for linkstation ls-wvl/vl Roger Shimizu
2016-01-21 14:38 ` [PATCH v3 3/7] ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wxl/wsxl Roger Shimizu
2016-01-21 14:38 ` [PATCH v3 4/7] ARM: dts: kirkwood: gpio-leds fixes for linkstation ls-wvl/vl Roger Shimizu
2016-01-21 14:38 ` [PATCH v3 5/7] ARM: dts: kirkwood: relicense dts of ls-wvl/vl and ls-wxl/wsxl under GPLv2/X11 Roger Shimizu
2016-01-21 14:38 ` [PATCH v3 6/7] ARM: dts: kirkwood: split lswxl dts to linkstation lswsxl and lswxl Roger Shimizu
2016-01-21 14:38 ` [PATCH v3 7/7] ARM: dts: kirkwood: split lswvl dts to linkstation lsvl and lswvl Roger Shimizu
2016-01-21 16:00 ` [PATCH v3 0/7] ARM: dts: kirkwood: fixes and split of linkstation dts for ls-wvl/vl and ls-wxl/wsxl Gregory CLEMENT
2016-01-21 16:05 ` Roger Shimizu
2016-01-21 16:18 ` Gregory CLEMENT
2016-01-21 16:23 ` Roger Shimizu
2016-01-25 15:17 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119144846.GI6554@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox