From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: allow vmalloc regions to be set with set_memory_*
Date: Thu, 28 Jan 2016 18:10:58 +0000 [thread overview]
Message-ID: <20160128181058.GQ775@arm.com> (raw)
In-Reply-To: <CAKv+Gu-GxicSKDq+Nm9H+dWrSVOhupozu4pZ=Pk7CzC_VrW=2Q@mail.gmail.com>
On Thu, Jan 28, 2016 at 05:43:41PM +0100, Ard Biesheuvel wrote:
> On 28 January 2016 at 16:08, Will Deacon <will.deacon@arm•com> wrote:
> > On Mon, Jan 18, 2016 at 03:01:05PM +0100, Ard Biesheuvel wrote:
> >> The range of set_memory_* is currently restricted to the module address
> >> range because of difficulties in breaking down larger block sizes.
> >> vmalloc maps PAGE_SIZE pages so it is safe to use as well. Update the
> >> function ranges and add a comment explaining why the range is restricted
> >> the way it is.
> >>
> >> Suggested-by: Laura Abbott <labbott@fedoraproject•org>
> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro•org>
> >> ---
> >> arch/arm64/mm/pageattr.c | 23 +++++++++++++++++++----
> >> 1 file changed, 19 insertions(+), 4 deletions(-)
> >
> > What's the user for this? It would be better to apply along with something
> > that actually needs to change permission for arbitrary vmalloc mappings.
> >
>
> BPF already uses set_memory_ro() but doesn't bother to check the return value.
Urgh :(
Then I can take it as a fix, if you like.
Will
next prev parent reply other threads:[~2016-01-28 18:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 14:01 [PATCH] arm64: allow vmalloc regions to be set with set_memory_* Ard Biesheuvel
2016-01-18 15:05 ` Mark Rutland
2016-01-28 15:08 ` Will Deacon
2016-01-28 16:40 ` Ard Biesheuvel
2016-01-28 16:43 ` Ard Biesheuvel
2016-01-28 18:10 ` Will Deacon [this message]
2016-01-28 19:07 ` Ard Biesheuvel
-- strict thread matches above, loose matches on Subject: below --
2016-01-12 21:46 [PATCH] arm64: Allow " Laura Abbott
2016-01-13 0:01 ` Alexei Starovoitov
2016-01-13 0:31 ` Daniel Borkmann
2016-01-13 14:03 ` Ard Biesheuvel
2016-01-13 16:10 ` Ard Biesheuvel
2016-01-14 23:01 ` Laura Abbott
2016-01-18 11:56 ` Mark Rutland
2016-01-28 1:47 ` Xishi Qiu
2016-01-28 10:51 ` Mark Rutland
2016-01-28 11:47 ` Xishi Qiu
2016-01-28 14:27 ` Mark Rutland
2016-01-29 1:21 ` Xishi Qiu
2016-01-29 11:02 ` Mark Rutland
2016-01-30 2:48 ` Xishi Qiu
2016-02-03 13:43 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128181058.GQ775@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox