From: broonie@kernel•org (Mark Brown)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A
Date: Fri, 29 Jan 2016 01:16:03 +0100 [thread overview]
Message-ID: <20160129001603.GM4130@sirena.org.uk> (raw)
In-Reply-To: <1453863463-30515-2-git-send-email-wenyou.yang@atmel.com>
On Wed, Jan 27, 2016 at 10:57:42AM +0800, Wenyou Yang wrote:
> +static const struct of_device_id act8945a_pmic_of_match[] = {
> + { .compatible = "active-semi,act8945a-regulator" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, act8945a_pmic_of_match);
This seems mostly OK but why do we have a compatible string here -
shouldn't the MFD be able to instantiate the regulator function without
needing this?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160129/cd5f0e17/attachment.sig>
next prev parent reply other threads:[~2016-01-29 0:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 2:57 [PATCH v4 0/2] regulator: act8945a: add regulator driver for the sub-device of ACT8945A MFD Wenyou Yang
2016-01-27 2:57 ` [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A Wenyou Yang
2016-01-29 0:16 ` Mark Brown [this message]
2016-01-29 1:20 ` Yang, Wenyou
2016-01-29 11:35 ` Mark Brown
2016-01-29 11:50 ` Javier Martinez Canillas
2016-01-29 12:03 ` Mark Brown
2016-02-01 5:54 ` Yang, Wenyou
2016-02-01 13:15 ` Javier Martinez Canillas
2016-02-02 2:26 ` Yang, Wenyou
2016-02-03 2:33 ` Yang, Wenyou
2016-02-03 17:47 ` Mark Brown
2016-02-04 13:28 ` Yang, Wenyou
2016-02-02 17:42 ` Peter Korsgaard
2016-02-03 2:29 ` Yang, Wenyou
2016-02-03 2:45 ` Krzysztof Kozlowski
2016-01-27 2:57 ` [PATCH v4 2/2] regulator: add documentation for ACT8945A's regulator DT bindings Wenyou Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129001603.GM4130@sirena.org.uk \
--to=broonie@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox