public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons•com (Thomas Petazzoni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/5] arm64: marvell: add Device Tree files for Armada 7K/8K
Date: Wed, 17 Feb 2016 15:06:08 +0100	[thread overview]
Message-ID: <20160217150608.2c9cdb02@free-electrons.com> (raw)
In-Reply-To: <56C356F8.8080105@arm.com>

Marc,

On Tue, 16 Feb 2016 17:06:00 +0000, Marc Zyngier wrote:

> > According to the datasheet I have, the GICD, GICC, GICV and GICH blocks
> > are all 0x10000 in size. Not sure the entire 0x10000 is actually used,
> > but th memory map is pretty clear.
> 
> No, that's just a way to make sure that you can give the GICV block to a
> guest while using 64k pages.
> 
> Talking about GICV: are you sure it is 0x10000 and not 0x20000? SBSA
> recommends to have the first 4kB GICV page aliased over 64kB, and the
> second 4kB page over the second 64kB block. That is to ensure that a
> hypervisor can trap access to GICV_DIR register independently of the
> rest of the virtual CPU interface.
> 
> But hey, almost everybody got it wrong so far, so I wouldn't be
> surprised if that was broken on this platform as well...

It seems like Marvell didn't get it wrong, and that my eyes were the
issue.

What I have in the datasheet is:

GICD 0x210000 0x21FFFF Distributor
GICC 0x220000 0x23FFFF Banked per CPU
GICV 0x240000 0x25FFFF Virtual Control
GICH 0x260000 0x27FFFF Hypervisor Control

So: GICD is 64 KB in size, while GICC, GICV and GICH are all 128 KB in
size. I'll fix that up in my v2.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-02-17 14:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15  8:47 [PATCH 0/5] arm64: Initial support for Marvell Armada 7K/8K Thomas Petazzoni
2016-02-15  8:47 ` [PATCH 1/5] Documentation: arm: improve Armada 37xx description Thomas Petazzoni
2016-02-15  8:47 ` [PATCH 2/5] Documentation: arm: add Marvell Armada 7K and 8K families Thomas Petazzoni
2016-02-15  8:47 ` [PATCH 3/5] Documentation: arm: improve Marvell EBU Armada documentation Thomas Petazzoni
2016-02-15  8:47 ` [PATCH 4/5] arm64: update ARCH_MVEBU for Marvell Armada 7K/8K support Thomas Petazzoni
2016-02-15  8:47 ` [PATCH 5/5] arm64: marvell: add Device Tree files for Armada 7K/8K Thomas Petazzoni
2016-02-15  9:32   ` Marc Zyngier
2016-02-16 16:31     ` Thomas Petazzoni
2016-02-16 17:06       ` Marc Zyngier
2016-02-17 14:06         ` Thomas Petazzoni [this message]
2016-02-16  5:42   ` Jisheng Zhang
2016-02-16 16:38     ` Thomas Petazzoni
2016-02-17  2:21       ` Jisheng Zhang
2016-02-17  8:30         ` Thomas Petazzoni
2016-02-15  9:24 ` [PATCH 0/5] arm64: Initial support for Marvell " Arnd Bergmann
2016-02-15  9:37   ` Thomas Petazzoni
2016-02-15  9:42     ` Arnd Bergmann
2016-02-15  9:26 ` [PATCH] ARM: documentation: update Marvell product listing Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160217150608.2c9cdb02@free-electrons.com \
    --to=thomas.petazzoni@free-electrons$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox