From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] clk: ti: Add support for dm814x ADPLL
Date: Wed, 17 Feb 2016 13:20:46 -0800 [thread overview]
Message-ID: <20160217212045.GE21202@atomide.com> (raw)
In-Reply-To: <20160217205257.2278.11639@quark.deferred.io>
* Michael Turquette <mturquette@baylibre•com> [160217 12:53]:
> Quoting Tony Lindgren (2016-02-17 09:39:49)
> > * Michael Turquette <mturquette@baylibre•com> [160216 17:32]:
> > >
> > > We have a shiny new series that provides a standard way to do this:
> > >
> > > http://lkml.kernel.org/r/<1455225554-13267-1-git-send-email-mturquette@baylibre.com>
> >
> > OK nice, so tagging the MPU and DDR clocks with CLK_IS_CRITICAL or
> > "clock-critical" should allow removing this code. I think in this
> > case I still need to set CLK_IS_CRITICAL as the clock is output 1
> > of the dts defined clock and does not have a separate dts node.
>
> In fact I hate clock-critical as a DT property and it's only there to
> support legacy DT bindings that store all clk data in DT and have zero
> clk data in C. So please use the CLK_IS_CRITICAL or CLK_ENABLE_HAND_OFF
> flags in C.
>
> Do you think you will ever have a driver that wants to gate these
> clocks? Probably not for MPU/DDR, but the HAND_OFF flag is a better fit
> if you do. It's the same as CRITICAL but transfers the prepare/enable
> reference counting to the consumer driver after that driver calls
> clk_get() and clk_prepare_enable() on the HAND_OFF clk.
OK I'll use CLK_ENABLE_HAND_OFF then. Who knows maybe somebody
somewhere has code running on one of the coprocessors in SRAM that
actually allows gating these :)
> > I can update when those patches hit Linux next, or I can do a
> > follow-up patch later on if we want to avoid the dependency
> > here. Which do you prefer?
>
> Well, testing is always welcome :-)
>
> If you rebase onto those patches then I'll add your patches to that
> series for testing and merge it that way.
OK will do and repost after some testing.
Regards,
Tony
next prev parent reply other threads:[~2016-02-17 21:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 21:20 [PATCHv5 0/2] Clock driver for dm814x and dra62x ADPLL Tony Lindgren
2016-02-12 21:20 ` [PATCH 1/2] dt-bindings: clock: adpll: Add binding documentation for TI adpll Tony Lindgren
2016-02-17 1:04 ` Michael Turquette
2016-02-17 17:28 ` Tony Lindgren
2016-02-12 21:20 ` [PATCH 2/2] clk: ti: Add support for dm814x ADPLL Tony Lindgren
2016-02-17 1:19 ` Michael Turquette
2016-02-17 17:39 ` Tony Lindgren
2016-02-17 20:52 ` Michael Turquette
2016-02-17 21:20 ` Tony Lindgren [this message]
2016-02-17 23:02 ` Michael Turquette
2016-02-23 13:47 ` Matthijs van Duin
2016-02-26 17:35 ` Tony Lindgren
2016-02-29 22:19 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217212045.GE21202@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox