From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] usb: chipidea: host: let the hcd know's parent device node
Date: Thu, 3 Mar 2016 15:42:47 +0100 [thread overview]
Message-ID: <20160303144247.GH15541@lunn.ch> (raw)
In-Reply-To: <1456999276-6315-3-git-send-email-peter.chen@nxp.com>
On Thu, Mar 03, 2016 at 06:01:15PM +0800, Peter Chen wrote:
> From: Peter Chen <peter.chen@freescale•com>
>
> Since the hcd (chipidea core device) has no device node, so
> if we want to describe the child node under the hcd, we had
> to put it under its parent's node (glue layer device), and
> in the code, we need to let the hcd knows glue layer's code,
> then the USB core can handle this node.
>
> Signed-off-by: Peter Chen <peter.chen@freescale•com>
> ---
> drivers/usb/chipidea/host.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
> index 053bac9..55120ef 100644
> --- a/drivers/usb/chipidea/host.c
> +++ b/drivers/usb/chipidea/host.c
> @@ -109,15 +109,25 @@ static int host_start(struct ci_hdrc *ci)
> struct ehci_hcd *ehci;
> struct ehci_ci_priv *priv;
> int ret;
> + struct device *dev = ci->dev;
>
> - if (usb_disabled())
> + if (usb_disabled() || !dev)
> return -ENODEV;
>
> - hcd = usb_create_hcd(&ci_ehci_hc_driver, ci->dev, dev_name(ci->dev));
> + /*
> + * USB Core will try to get child node under roothub,
> + * but chipidea core has no of_node, and the child node
> + * for controller is located at glue layer's node which
> + * is chipidea core's parent.
> + */
> + if (dev->parent && dev->parent->of_node)
> + dev->of_node = dev->parent->of_node;
Is this a good idea? Two devices with the same of_node?
I know the networking code assumes of_node values are unique, and uses
it to find a device. Are you 100% sure the USB code does not make this
assumption.
Andrew
next prev parent reply other threads:[~2016-03-03 14:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 10:01 [PATCH 0/3] Add power sequence for hard-wired USB devices Peter Chen
2016-03-03 10:01 ` [PATCH 1/3] usb: core: add power sequence for " Peter Chen
2016-03-03 18:31 ` Alan Stern
2016-03-04 2:07 ` Peter Chen
2016-03-03 20:54 ` Rob Herring
2016-03-04 2:02 ` Peter Chen
2016-03-04 2:23 ` Andrew Lunn
2016-03-04 2:37 ` Peter Chen
2016-03-05 4:28 ` Rob Herring
2016-03-05 8:33 ` Peter Chen
2016-03-05 14:10 ` Andrew Lunn
2016-03-14 10:42 ` Peter Chen
2016-04-05 9:35 ` Peter Chen
2016-03-03 10:01 ` [PATCH 2/3] usb: chipidea: host: let the hcd know's parent device node Peter Chen
2016-03-03 14:42 ` Andrew Lunn [this message]
2016-03-04 1:53 ` Peter Chen
2016-03-04 2:17 ` Andrew Lunn
2016-03-04 2:32 ` Peter Chen
2016-03-03 10:01 ` [PATCH 3/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
2016-03-03 22:30 ` Maciej S. Szmigiero
2016-03-04 2:04 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303144247.GH15541@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox