From: treding@nvidia•com (Thierry Reding)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y
Date: Mon, 14 Mar 2016 13:18:24 +0100 [thread overview]
Message-ID: <20160314121823.GE22912@ulmo.nvidia.com> (raw)
In-Reply-To: <1457787029-9168-1-git-send-email-andy.yan@kernel-upstream.org>
On Sat, Mar 12, 2016 at 08:50:29PM +0800, Andy Yan wrote:
> All the current rk3066 based boards use pwm modulate vdd_logic
> voltage, the board may hang when the system boot and run to a higher
> frequency without pwm enabled, so enable it as builtin.
I don't understand the rationale here. Surely if the system can't safely
switch to a higher frequency because the regulator isn't available, then
it should be prevented from switching, shouldn't it?
Making this change alone will not prevent users from switching this back
to =m on their own. So either you need to add code to prevent a switch
to an unsupported frequency in the absence of the regulator, or you need
to change the PWM_ROCKCHIP Kconfig option to be bool instead, though the
latter is of course a somewhat ugly hack, whereas the former would be a
proper fix.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160314/ba929e88/attachment-0001.sig>
prev parent reply other threads:[~2016-03-14 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 12:50 [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y Andy Yan
2016-03-12 12:51 ` [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y Andy Yan
2016-03-14 12:21 ` Thierry Reding
2016-03-14 12:18 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314121823.GE22912@ulmo.nvidia.com \
--to=treding@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox