From: mchehab@osg•samsung.com (Mauro Carvalho Chehab)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] [media] media: rename media unregister function
Date: Fri, 18 Mar 2016 21:49:27 -0300 [thread overview]
Message-ID: <20160318214927.507f715a@recife.lan> (raw)
In-Reply-To: <56EC0EA3.6010108@linux.intel.com>
Em Fri, 18 Mar 2016 16:20:19 +0200
Sakari Ailus <sakari.ailus@linux•intel.com> escreveu:
> Shuah Khan wrote:
> > On 03/18/2016 08:12 AM, Javier Martinez Canillas wrote:
> >> Hello Shuah,
> >>
> >> On 03/18/2016 11:01 AM, Shuah Khan wrote:
> >>> On 03/18/2016 07:05 AM, Mauro Carvalho Chehab wrote:
> >>>> Now that media_device_unregister() also does a cleanup, rename it
> >>>> to media_device_unregister_cleanup().
> >>>>
> >>>> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg•samsung.com>
> >>>
> >>> I think adding cleanup is redundant. media_device_unregister()
> >>> would imply that there has to be some cleanup releasing resources.
> >>> I wouldn't make this change.
> >>>
> >>
> >> Problem is that there is a media_device_init() and media_device_register(),
> >> so having both unregister and cleanup in this function will make very clear
> >> that a single function is the counter part of the previous two operations.
> >>
> >
> > Yes. I realized that this change is motivated by the fact that there is
> > the media_device_init() and we had the counterpart media_device_cleanup()
> > as an exported function. I still think there is no need to make the change
> > to add _cleanup() at the end of media_device_unregister(). It can be handled
> > in API documentation that it does both.
>
> I think that's a bad idea. People will only read the documentation when
> something doesn't work. In this case it's easy to miss that.
After thinking about that, I guess the best is to use kref only
if the media_device_*devres functions are used. With this, we don't
need to touch at media_device_cleanup().
Just the patch to the ML:
https://patchwork.linuxtv.org/patch/33533/
It was tested with HVR-950Q.
Regards,
Mauro
prev parent reply other threads:[~2016-03-19 0:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 13:05 [PATCH] [media] media: rename media unregister function Mauro Carvalho Chehab
2016-03-18 13:48 ` Javier Martinez Canillas
2016-03-18 14:01 ` Shuah Khan
2016-03-18 14:12 ` Javier Martinez Canillas
2016-03-18 14:17 ` Shuah Khan
2016-03-18 14:20 ` Sakari Ailus
2016-03-19 0:49 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318214927.507f715a@recife.lan \
--to=mchehab@osg$(echo .)samsung.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox