Subject: [PATCH 1/4] drivers/bus: make brcmstb_gisb.c driver explicitly non-modular

From: [email-masked] (Brian Norris)
Date: Wed, 6 Apr 2016 18:26:39 -0700

On Sun, Mar 27, 2016 at 05:10:55PM -0400, Paul Gortmaker wrote:
> The Kconfig for this driver is currently:
> 
> config BRCMSTB_GISB_ARB
>         bool "Broadcom STB GISB bus arbiter"
> 
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove all modular references, so that when reading the driver
> there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> Cc: Brian Norris <[email-masked]>
> Cc: Gregory Fong <[email-masked]>
> Cc: Florian Fainelli <[email-masked]>
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Paul Gortmaker <[email-masked]>

I think this driver probably doesn't make too much sense as a module
anyway (among other things, we can't hook the ARM fault handler beyond
init time, as it's marked __init). So:

Acked-by: Brian Norris <[email-masked]>

Might be good to get Florian's ack though, as I'm not using this
platform any more.

Brian

> ---
>  drivers/bus/brcmstb_gisb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
> index f364fa4d24eb..319104b22ca4 100644
> --- a/drivers/bus/brcmstb_gisb.c
> +++ b/drivers/bus/brcmstb_gisb.c
> @@ -13,7 +13,6 @@
>  
>  #include <linux/init.h>
>  #include <linux/types.h>
> -#include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/interrupt.h>
>  #include <linux/sysfs.h>
> @@ -408,5 +407,4 @@ static int __init brcm_gisb_driver_init(void)
>  	return platform_driver_probe(&brcmstb_gisb_arb_driver,
>  				     brcmstb_gisb_arb_probe);
>  }
> -
> -module_init(brcm_gisb_driver_init);
> +device_initcall(brcm_gisb_driver_init);
> -- 
> 2.6.1
>