From: thierry.reding@gmail•com (Thierry Reding)
To: linux-arm-kernel@lists•infradead.org
Subject: [RESEND 08/11] pwm: sti: Add support for PWM Capture IRQs
Date: Tue, 12 Apr 2016 12:35:21 +0200 [thread overview]
Message-ID: <20160412103521.GD18882@ulmo.ba.sec> (raw)
In-Reply-To: <1456932729-9667-9-git-send-email-lee.jones@linaro.org>
On Wed, Mar 02, 2016 at 03:32:06PM +0000, Lee Jones wrote:
[...]
> diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c
[...]
> +static irqreturn_t sti_pwm_interrupt(int irq, void *data)
> +{
> + struct sti_pwm_chip *pc = data;
> + struct device *dev = pc->dev;
> + struct sti_cpt_data *d;
> + int channel;
> + int cpt_int_stat;
> + int reg;
> + int ret = IRQ_NONE;
> +
> + ret = regmap_field_read(pc->pwm_cpt_int_stat, &cpt_int_stat);
> + if (ret)
> + return ret;
> +
> + while (cpt_int_stat) {
> + channel = ffs(cpt_int_stat) - 1;
> +
> + d = pc->cpt_data[channel];
> +
> + /*
> + * Capture input:
> + * _______ _______
> + * | | | |
> + * __| |_________________| |________
> + * ^0 ^1 ^2
> + *
> + * Capture start by the first available rising edge
> + * When a capture event occurs, capture value (CPT_VALx)
> + * is stored, index incremented, capture edge changed.
> + *
> + * After the capture, if the index > 1, we have collected
> + * the necessary data so we signal the thread waiting for it
> + * and disable the capture by setting capture edge to none
> + *
> + */
How do you deal with the situation where someone will stop the PWM
signal half-way in? That is, suppose you've got events for the first and
second snapshots (0 and 1) and then someone stops the PWM and the event
for snapshot 2 never happens, how does the code recover?
> +
> + regmap_read(pc->regmap,
> + PWM_CPT_VAL(channel), &d->snapshot[d->index]);
> +
> + switch (d->index) {
> + case 0:
> + case 1:
> + regmap_read(pc->regmap, PWM_CPT_EDGE(channel), ®);
> + reg ^= PWM_CPT_EDGE_MASK;
> + regmap_write(pc->regmap, PWM_CPT_EDGE(channel), reg);
> +
> + d->index++;
> + break;
> + case 2:
> + regmap_write(pc->regmap,
> + PWM_CPT_EDGE(channel), CPT_EDGE_DISABLED);
> + wake_up(&d->wait);
> + break;
> + default:
> + dev_err(dev, "Internal error\n");
> + }
> +
> + clear_bit(channel, (unsigned long int *)&cpt_int_stat);
clear_bit() is a little unusual to use on regular data types, as
evidenced by the need for the goofy cast here.
> +
> + ret = IRQ_HANDLED;
> + }
> +
> + /* Just ACK everything */
> + regmap_write(pc->regmap, PWM_INT_ACK, PWM_INT_ACK_MASK);
> +
> + return ret;
> +}
> +
> static int sti_pwm_probe_dt(struct sti_pwm_chip *pc)
> {
> struct device *dev = pc->dev;
> @@ -354,6 +425,11 @@ static int sti_pwm_probe_dt(struct sti_pwm_chip *pc)
> if (IS_ERR(pc->pwm_cpt_int_en))
> return PTR_ERR(pc->pwm_cpt_int_en);
>
> + pc->pwm_cpt_int_stat = devm_regmap_field_alloc(dev, pc->regmap,
> + reg_fields[PWM_CPT_INT_STAT]);
> + if (IS_ERR(pc->pwm_cpt_int_stat))
> + return PTR_ERR(pc->pwm_cpt_int_stat);
> +
> return 0;
> }
>
> @@ -371,7 +447,7 @@ static int sti_pwm_probe(struct platform_device *pdev)
> struct sti_pwm_chip *pc;
> struct resource *res;
> unsigned int chan;
> - int ret;
> + int ret, irq;
>
> pc = devm_kzalloc(dev, sizeof(*pc), GFP_KERNEL);
> if (!pc)
> @@ -392,6 +468,19 @@ static int sti_pwm_probe(struct platform_device *pdev)
> if (IS_ERR(pc->regmap))
> return PTR_ERR(pc->regmap);
>
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0) {
> + dev_err(&pdev->dev, "Failed to obtain IRQ\n");
> + return -ENODEV;
> + }
I think you need to propagate the return value of platform_get_irq()
here.
> +
> + ret = devm_request_irq(&pdev->dev, irq, sti_pwm_interrupt,
> + 0, pdev->name, (void *) pc);
No need for the explicit cast to void *.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160412/53a2b6d2/attachment.sig>
next prev parent reply other threads:[~2016-04-12 10:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 15:31 [RESEND 00/11] pwm: Add support for PWM Capture Lee Jones
2016-03-02 15:31 ` [RESEND 01/11] pwm: Add PWM Capture support Lee Jones
2016-04-12 10:08 ` Thierry Reding
2016-04-13 9:36 ` Lee Jones
2016-04-13 14:50 ` Thierry Reding
2016-03-02 15:32 ` [RESEND 02/11] pwm: sysfs: " Lee Jones
2016-04-12 10:15 ` Thierry Reding
2016-04-13 9:40 ` Lee Jones
2016-03-02 15:32 ` [RESEND 03/11] pwm: sti: Reorganise register names in preparation for new functionality Lee Jones
2016-03-02 15:32 ` [RESEND 04/11] pwm: sti: Only request clock rate when you need to Lee Jones
2016-03-02 15:32 ` [RESEND 05/11] pwm: sti: Supply PWM Capture register addresses and bit locations Lee Jones
2016-03-02 15:32 ` [RESEND 06/11] pwm: sti: Supply PWM Capture clock handling Lee Jones
2016-03-02 15:32 ` [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data Lee Jones
2016-04-12 10:29 ` Thierry Reding
2016-04-15 12:39 ` Lee Jones
2016-04-15 14:22 ` Thierry Reding
2016-04-15 14:31 ` Lee Jones
2016-04-15 13:11 ` Lee Jones
2016-04-15 14:23 ` Thierry Reding
2016-03-02 15:32 ` [RESEND 08/11] pwm: sti: Add support for PWM Capture IRQs Lee Jones
2016-04-12 10:35 ` Thierry Reding [this message]
2016-04-13 10:05 ` Lee Jones
2016-04-13 15:16 ` Thierry Reding
2016-03-02 15:32 ` [RESEND 09/11] pwm: sti: Add PWM Capture call-back Lee Jones
2016-04-12 10:53 ` Thierry Reding
2016-04-13 10:25 ` Lee Jones
2016-04-13 15:22 ` Thierry Reding
2016-04-15 8:29 ` Lee Jones
2016-04-15 14:20 ` Thierry Reding
2016-03-02 15:32 ` [RESEND 10/11] pwm: sti: Enable PWM Capture Lee Jones
2016-04-12 10:56 ` Thierry Reding
2016-03-02 15:32 ` [RESEND 11/11] pwm: sti: Take the opportunity to conduct a little house keeping Lee Jones
2016-04-12 7:28 ` [RESEND 00/11] pwm: Add support for PWM Capture Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412103521.GD18882@ulmo.ba.sec \
--to=thierry.reding@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox