From: thomas.petazzoni@free-electrons•com (Thomas Petazzoni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] pci: host: new driver for Marvell Armada 7K/8K PCIe controller
Date: Thu, 14 Apr 2016 16:25:28 +0200 [thread overview]
Message-ID: <20160414162528.678be5b7@free-electrons.com> (raw)
In-Reply-To: <20160411175651.5f32a990@free-electrons.com>
Hello,
On Mon, 11 Apr 2016 17:56:51 +0200, Thomas Petazzoni wrote:
> > > + struct pcie_port *pp = arg;
> > > + struct armada8k_pcie *pcie = to_armada8k_pcie(pp);
> > > + void __iomem *base = pcie->base;
> > > + u32 val;
> > > +
> > > + val = readl(base + PCIE_GLOBAL_INT_CAUSE1_REG);
> > > + writel(val, base + PCIE_GLOBAL_INT_CAUSE1_REG);
> > > +
> > > + return IRQ_HANDLED;
> >
> > Maybe a comment as to why you are just throwing them away.
>
> I'll have a look into this.
Enabling the INT A-D interrupts is needed for the PCI device drivers to
receive interrupts from their respective PCI devices. But then, once
you enable the INT A-D interrupts, they are also latched into the PCIe
controller, so if you don't acknowledge them in the PCIe controller
level, at the first interrupt coming from a PCI device, the system
hangs. I've added a comment in the driver about this.
> Is this needed? The clocks are registered in of_clk_init(), i.e at
> time_init() time. This is way before the device drivers get probed, no?
The clock drivers are now regular platform drivers, so I'll add the
EPROBE_DEFER handling logic.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-14 14:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 9:30 [PATCH 0/2] pci: host: new driver for Marvell Armada 7K/8K PCIe controller Thomas Petazzoni
2016-03-27 9:30 ` [PATCH 1/2] dt-bindings: pci: add DT binding " Thomas Petazzoni
2016-03-28 20:46 ` Rob Herring
2016-03-28 21:18 ` Arnd Bergmann
2016-04-14 13:33 ` Thomas Petazzoni
2016-03-27 9:30 ` [PATCH 2/2] pci: host: new driver " Thomas Petazzoni
2016-03-27 14:03 ` Andrew Lunn
2016-04-11 15:56 ` Thomas Petazzoni
2016-04-14 14:25 ` Thomas Petazzoni [this message]
2016-03-28 21:21 ` Arnd Bergmann
2016-04-14 14:26 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414162528.678be5b7@free-electrons.com \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox