From: thierry.reding@gmail•com (Thierry Reding)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: tegra: fix naming in GPIO DT binding header
Date: Fri, 22 Apr 2016 13:24:06 +0200 [thread overview]
Message-ID: <20160422112406.GB9047@ulmo.ba.sec> (raw)
In-Reply-To: <CACRpkdZxeV07_rb2xL+HRGp-ay1B-U=_tEbPCYqvM+ZYD-wpYQ@mail.gmail.com>
On Mon, Apr 11, 2016 at 09:04:09AM +0200, Linus Walleij wrote:
> On Wed, Apr 6, 2016 at 7:32 PM, Stephen Warren <swarren@wwwdotorg•org> wrote:
> > On 04/06/2016 11:28 AM, Thierry Reding wrote:
> >>
> >> On Tue, Apr 05, 2016 at 01:25:07PM -0600, Stephen Warren wrote:
> >>>
> >>> From: Stephen Warren <swarren@nvidia•com>
> >>>
> >>> According to the Tegra TRM, GPIOs are aggregated into /ports/ of 8 GPIOs,
> >>> not into /banks/. Fix <dt-bindings/gpio/tegra-gpio.h> to correctly
> >>> reflect
> >>> this naming convention. While this seems like silly churn, it will become
> >>> slightly more important once we introduce the GPIO binding for upcoming
> >>> Tegra chips.
> >>>
> >>> Signed-off-by: Stephen Warren <swarren@nvidia•com>
> >>> ---
> >>> include/dt-bindings/gpio/tegra-gpio.h | 68
> >>> +++++++++++++++++------------------
> >>> 1 file changed, 34 insertions(+), 34 deletions(-)
> >>
> >>
> >> It's not clear to me where this should be applied. This is technically
> >> part of the GPIO controller bindings, in which case it'd need to go via
> >> the GPIO tree. I'm fine with taking it through the Tegra tree, too, but
> >> in case you agree that it should go through the GPIO tree:
> >>
> >> Acked-by: Thierry Reding <treding@nvidia•com>
> >
> > I typically consider bindings part of the SoC code-base they related to, so
> > I'd imagine this going through the Tegra tree. I didn't Cc LinusW on the
> > patch because of that thinking and oversight, but have done so now just in
> > case he feels strongly.
>
> No strong opinion, only time I care is when we merge a new driver
> and it #includes <dt-bindings/...>.
>
> Take it through the tegra tree.
> Acked-by: Linus Walleij <linus.walleij@linaro•org>
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160422/0f5b4c7d/attachment.sig>
prev parent reply other threads:[~2016-04-22 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 19:25 [PATCH] ARM: tegra: fix naming in GPIO DT binding header Stephen Warren
2016-04-06 17:28 ` Thierry Reding
2016-04-06 17:32 ` Stephen Warren
2016-04-11 7:04 ` Linus Walleij
2016-04-22 11:24 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422112406.GB9047@ulmo.ba.sec \
--to=thierry.reding@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox