From: eric.engestrom@imgtec•com (Eric Engestrom)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] ARM: remove duplicate const qualifier
Date: Mon, 25 Apr 2016 13:58:09 +0100 [thread overview]
Message-ID: <20160425125809.GP32731@imgtec.com> (raw)
In-Reply-To: <4641918.pNBP5iAK01@wuerfel>
On Mon, Apr 25, 2016 at 01:38:18PM +0200, Arnd Bergmann wrote:
> Maybe say you you found it (llvm, sparse, coccinelle?), and why this
> is causing a problem for anyone. If it's just unnecessary but not
> harmful, I'd probably ignore the patch.
$ grep -rE '(^|\W)const(\s+\w+)+\s+const\s'
I just happened to notice some unnecessary const in our internal code,
so I grep'ed for it in a couple big OSS projects to see how common it
was. Since I found only a few, I decided to remove them, but like I said
it just gets ignored by all the compilers I know, so there's absolutely
no harm in leaving this dead code around.
> That's fine. Having multiple patches here is slightly better than just
> one, but I'd also be fine with just taking the large patch because it
> is an identical trivial change in multiple files.
So, do you want me to split them up? I'd prefer not having to (slightly
less work for me :P), but it doesn't really make much of a difference
either way.
Cheers
next prev parent reply other threads:[~2016-04-25 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1461577678-29517-1-git-send-email-eric.engestrom@imgtec.com>
2016-04-25 9:47 ` [PATCH 2/4] drivers: firmware: psci: remove duplicate const qualifier Eric Engestrom
2016-04-25 10:33 ` Jisheng Zhang
2016-04-25 9:47 ` [PATCH 3/4] dmaengine: pxa_dma: " Eric Engestrom
2016-04-25 19:18 ` Robert Jarzmik
2016-04-26 16:30 ` Vinod Koul
2016-04-25 9:47 ` [PATCH 4/4] ARM: " Eric Engestrom
2016-04-25 9:52 ` Viresh Kumar
2016-04-25 9:57 ` Alexandre Belloni
2016-04-25 10:39 ` Eric Engestrom
2016-04-25 11:38 ` Arnd Bergmann
2016-04-25 12:58 ` Eric Engestrom [this message]
2016-04-25 14:12 ` Nicolas Pitre
2016-04-25 14:37 ` Eric Engestrom
2016-04-26 10:12 ` Krzysztof Hałasa
2016-04-27 20:01 ` Nicolas Pitre
2016-04-25 10:59 ` Sylvain Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425125809.GP32731@imgtec.com \
--to=eric.engestrom@imgtec$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox