Subject: [linux-sunxi] Re: [PATCH 2/3] sunxi: A20-OLinuXino-LIME2: Add usb-power-supply

From: [email-masked] (Maxime Ripard)
Date: Mon, 2 May 2016 13:07:09 +0200

On Sun, May 01, 2016 at 08:46:28AM +0200, Michael Haas wrote:
> Hi Maxime,
> 
> 
> On 04/02/2016 12:36 PM, Maxime Ripard wrote:
> > Hi,
> > 
> > On Fri, Mar 25, 2016 at 08:04:06PM +0100, Michael Haas wrote:
> >> The A20-OLinuXino-LIME2 uses the AXP209 PMIC. This patch adds the
> >> corresponding usb-power-supply node to the DTS.
> >> If CONFIG_AXP20X_POWER is set, this patch enables the /sys/class/power_supply/
> >> diirectory.
> >>
> >> Signed-off-by: Michael Haas <[email-masked]>
> > 
> > Is there *any* reason to not use the AXP209 dtsi where it's already
> > defined?
> > 
> 
> do you have any preference for this being in the AXP209 dtsi? I've been
> thinking about it and it makes sense to enable the power supply nodes
> for all devices using the AXP209. They will just report themselves as
> offline if the PMIC indicates nothing is connected.

Yes, I'd prefer that a lot :)

It avoids enabling it on all the boards.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160502/c0040715/attachment-0001.sig>