public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: thierry.reding@gmail•com (Thierry Reding)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] of: add common OF-based component functionality
Date: Fri, 3 Jun 2016 17:44:30 +0200	[thread overview]
Message-ID: <20160603154430.GA21013@ulmo.ba.sec> (raw)
In-Reply-To: <E1b8pyR-0005OJ-V3@rmk-PC.armlinux.org.uk>

On Fri, Jun 03, 2016 at 03:21:19PM +0100, Russell King wrote:
[...]
> diff --git a/drivers/of/of_component.c b/drivers/of/of_component.c
[...]
> +static void component_compare_of(struct device *dev, void *data)
> +{
> +	return dev->of_node == data;
> +}

The return statement here doesn't match the return value. Didn't GCC
complain about this?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160603/196b25a6/attachment.sig>

  parent reply	other threads:[~2016-06-03 15:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  7:58 [PATCH] drm: convert DT component matching to component_match_add_release() Russell King
2016-06-03  9:40 ` Liviu Dudau
2016-06-03 10:36   ` Russell King - ARM Linux
2016-06-03 11:19     ` Liviu Dudau
2016-06-03 11:48       ` Russell King - ARM Linux
2016-06-03 10:56 ` Robin Murphy
2016-06-03 14:15   ` Russell King - ARM Linux
2016-06-03 14:21     ` [PATCH v2 1/3] of: add common OF-based component functionality Russell King
2016-06-03 15:29       ` Rob Herring
2016-06-03 15:36         ` Russell King - ARM Linux
2016-06-03 19:52           ` Rob Herring
2016-06-03 15:44       ` Thierry Reding [this message]
2016-06-03 16:11         ` Russell King - ARM Linux
2016-06-03 14:21     ` [PATCH v2 2/3] drm: convert DT component matching to component_match_add_release() Russell King
2016-06-03 15:10       ` Lucas Stach
2016-06-07 13:39       ` Liviu Dudau
2016-06-07 14:26       ` Vincent ABRIOU
2016-06-03 14:21     ` [PATCH v2 3/3] iommu: " Russell King
2016-06-03 15:20       ` Matthias Brugger
2016-06-15 13:31       ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160603154430.GA21013@ulmo.ba.sec \
    --to=thierry.reding@gmail$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox