From: briannorris@chromium•org (Brian Norris)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 11/14] regulator: pwm: properly initialize the ->state field
Date: Fri, 3 Jun 2016 13:51:17 -0700 [thread overview]
Message-ID: <20160603205117.GI124478@google.com> (raw)
In-Reply-To: <1464942192-25967-12-git-send-email-boris.brezillon@free-electrons.com>
On Fri, Jun 03, 2016 at 10:23:09AM +0200, Boris Brezillon wrote:
> The ->state field is currently initialized to 0, thus referencing the
> voltage selector at index 0, which might not reflect the current voltage
> value.
> If possible, retrieve the current voltage selector from the PWM state, else
> return -EINVAL.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons•com>
> ---
> Heiko, Mark,
>
> I know you already added your Tested-by/Acked-by tags on this patch
> but this version has slightly change and is now making use of the
> pwm_get_relative_duty_cycle() helper instead of manually converting
> the absolute duty_cycle value into a relative one.
> ---
> drivers/regulator/pwm-regulator.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
Tested-by: Brian Norris <briannorris@chromium•org>
next prev parent reply other threads:[~2016-06-03 20:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 8:22 [PATCH 00/14] regulator: pwm: various improvements Boris Brezillon
2016-06-03 8:22 ` [PATCH 01/14] pwm: Add new helpers to create/manipulate PWM states Boris Brezillon
2016-06-03 8:23 ` [PATCH 02/14] regulator: pwm: Drop unneeded pwm_enable() call Boris Brezillon
2016-06-03 11:08 ` Applied "regulator: pwm: Drop unneeded pwm_enable() call" to the regulator tree Mark Brown
2016-06-03 8:23 ` [PATCH 03/14] pwm: rockchip: Fix period and duty_cycle approximation Boris Brezillon
2016-06-03 20:03 ` Brian Norris
2016-06-04 6:19 ` Boris Brezillon
2016-06-07 17:25 ` Brian Norris
2016-06-03 8:23 ` [PATCH 04/14] pwm: rockchip: Add support for hardware readout Boris Brezillon
2016-06-03 20:07 ` Brian Norris
2016-06-03 20:20 ` Brian Norris
2016-06-04 6:24 ` Boris Brezillon
2016-06-07 17:26 ` Brian Norris
2016-06-03 8:23 ` [PATCH 05/14] pwm: rockchip: Avoid glitches on already running PWMs Boris Brezillon
2016-06-03 20:28 ` Brian Norris
2016-06-04 6:26 ` Boris Brezillon
2016-06-03 8:23 ` [PATCH 06/14] pwm: rockchip: Add support for atomic update Boris Brezillon
2016-06-03 20:37 ` Brian Norris
2016-06-03 8:23 ` [PATCH 07/14] pwm: sti: Add support for hardware readout Boris Brezillon
2016-06-03 8:23 ` [PATCH 08/14] pwm: sti: Avoid glitches on already running PWMs Boris Brezillon
2016-06-03 20:38 ` Brian Norris
2016-06-03 8:23 ` [PATCH 09/14] regulator: pwm: Adjust PWM config at probe time Boris Brezillon
2016-06-03 20:41 ` Brian Norris
2016-06-03 8:23 ` [PATCH 10/14] regulator: pwm: Switch to the atomic PWM API Boris Brezillon
2016-06-03 20:50 ` Brian Norris
2016-06-04 6:28 ` Boris Brezillon
2016-06-06 6:14 ` Laxman Dewangan
2016-06-03 8:23 ` [PATCH 11/14] regulator: pwm: properly initialize the ->state field Boris Brezillon
2016-06-03 20:51 ` Brian Norris [this message]
2016-06-03 8:23 ` [PATCH 12/14] regulator: pwm: Retrieve correct voltage Boris Brezillon
2016-06-03 20:55 ` Brian Norris
2016-06-03 8:23 ` [PATCH 13/14] regulator: pwm: Support extra continuous mode cases Boris Brezillon
2016-06-03 21:03 ` Brian Norris
2016-06-04 6:30 ` Boris Brezillon
2016-06-03 8:23 ` [PATCH 14/14] regulator: pwm: Document pwm-dutycycle-unit and pwm-dutycycle-range Boris Brezillon
2016-06-03 21:04 ` Brian Norris
2016-06-06 14:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603205117.GI124478@google.com \
--to=briannorris@chromium$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox