Subject: [RESEND PATCHv2 04/28] ARM: OMAP2+: hwmod: use new ti_clk_get API to search for clock handles

From: [email-masked] (Tony Lindgren)
Date: Mon, 27 Jun 2016 23:57:12 -0700

Hi,

* Tero Kristo <[email-masked]> [160613 12:07]:
> The new API avoids the need to add clock aliases for most of the clocks,
> should use of it is preferred. Many of the existing clock aliases are
> only created because of hwmod data.
> 
> Signed-off-by: Tero Kristo <[email-masked]>
> ---
>  arch/arm/mach-omap2/omap_hwmod.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 83cb527..0ea869c 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -786,7 +786,7 @@ static int _init_main_clk(struct omap_hwmod *oh)
>  	if (!oh->main_clk)
>  		return 0;
>  
> -	oh->_clk = clk_get(NULL, oh->main_clk);
> +	oh->_clk = ti_clk_get(oh->main_clk);
>  	if (IS_ERR(oh->_clk)) {
>  		pr_warn("omap_hwmod: %s: cannot clk_get main_clk %s\n",
>  			oh->name, oh->main_clk);

After thinking about this for a while I think code outside TI specific
clock implementation should use just clk_get(). Otherwise we create more
dependencies to move code to live under drivers subdirectory.

Can't we have clk_get() call a SoC specific helper function if clock
is not found?

Regards,

Tony