From: thierry.reding@gmail•com (Thierry Reding)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] pwm: lpc32xx: Set PWM_PIN_LEVEL bit to default value
Date: Mon, 11 Jul 2016 10:55:23 +0200 [thread overview]
Message-ID: <20160711085523.GC5823@ulmo.ba.sec> (raw)
In-Reply-To: <1467032997-5340-2-git-send-email-slemieux.tyco@gmail.com>
On Mon, Jun 27, 2016 at 09:09:55AM -0400, Sylvain Lemieux wrote:
> From: Sylvain Lemieux <slemieux@tycoint•com>
>
> The PWM_PIN_LEVEL bit is leave unset by the kernel PWM driver.
>
> Prior to commit 08ee77b5a5de27ad63c92262ebcb4efe0da93b58,
> the PWM_PIN_LEVEL bit was always clear when the PWM was disable
> and a 0 logic level was apply to the output.
>
> According to the LPC32x0 User Manual [1],
> the default value for bit 30 (PWM_PIN_LEVEL) is 0.
>
> This change initialize the pin level to 0 (default value) and
> update the register value accordingly.
>
> [1] http://www.nxp.com/documents/user_manual/UM10326.pdf
>
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint•com>
> ---
> Changes from v1 to v2:
> * Only setup the "PWMx_PIN_LEVEL" once on probe.
>
> drivers/pwm/pwm-lpc32xx.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160711/1096e082/attachment.sig>
next prev parent reply other threads:[~2016-07-11 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 13:09 [PATCH v2 0/3] pwm: lpc32xx: Add support to control PWM_PIN_LEVEL bit Sylvain Lemieux
2016-06-27 13:09 ` [PATCH v2 1/3] pwm: lpc32xx: Set PWM_PIN_LEVEL bit to default value Sylvain Lemieux
2016-07-11 8:55 ` Thierry Reding [this message]
2016-06-27 13:09 ` [PATCH v2 2/3] pwm: lpc32xx: Add support for PWM_PIN_LEVEL bit configuration Sylvain Lemieux
2016-06-27 13:09 ` [PATCH v2 3/3] dt-bindings: pwm: lpc32xx: Add nxp, pwm-disabled-level-high property Sylvain Lemieux
2016-06-30 8:43 ` [PATCH v2 0/3] pwm: lpc32xx: Add support to control PWM_PIN_LEVEL bit Vladimir Zapolskiy
2016-06-30 13:25 ` Sylvain Lemieux
2016-07-01 8:13 ` Vladimir Zapolskiy
2016-07-04 14:08 ` Sylvain Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711085523.GC5823@ulmo.ba.sec \
--to=thierry.reding@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox